Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: webkit/appcache/view_appcache_internals_job.cc

Issue 10824033: Coverity: Fix several pass-by-values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win build fix. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « skia/ext/skia_sandbox_support_win.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/appcache/view_appcache_internals_job.cc
diff --git a/webkit/appcache/view_appcache_internals_job.cc b/webkit/appcache/view_appcache_internals_job.cc
index da6ff636f93810c2af1db843915768754d9ff2e5..94ee6015f2d65f28d92a30161bd27a68c99aaaca 100644
--- a/webkit/appcache/view_appcache_internals_job.cc
+++ b/webkit/appcache/view_appcache_internals_job.cc
@@ -276,7 +276,7 @@ void EmitHexDump(const char *buf, size_t buf_len, size_t total_len,
out->append("</pre>");
}
-GURL DecodeBase64URL(const std::string base64) {
+GURL DecodeBase64URL(const std::string& base64) {
std::string url;
base::Base64Decode(base64, &url);
return GURL(url);
« no previous file with comments | « skia/ext/skia_sandbox_support_win.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698