Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: ppapi/native_client/src/trusted/plugin/plugin.h

Issue 10824033: Coverity: Fix several pass-by-values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win build fix. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/native_client/src/trusted/plugin/plugin.h
diff --git a/ppapi/native_client/src/trusted/plugin/plugin.h b/ppapi/native_client/src/trusted/plugin/plugin.h
index ce6df11287d4db966732459b86a07a4cdc700a9d..71ff2901643596b73c594de1711b047dcc3f6f8e 100644
--- a/ppapi/native_client/src/trusted/plugin/plugin.h
+++ b/ppapi/native_client/src/trusted/plugin/plugin.h
@@ -202,11 +202,13 @@ class Plugin : public pp::InstancePrivate {
// plugin_base_url is the URL used for resolving relative URLs used in
// src="...".
nacl::string plugin_base_url() const { return plugin_base_url_; }
- void set_plugin_base_url(nacl::string url) { plugin_base_url_ = url; }
+ void set_plugin_base_url(const nacl::string& url) { plugin_base_url_ = url; }
// manifest_base_url is the URL used for resolving relative URLs mentioned
// in manifest files. If the manifest is a data URI, this is an empty string.
nacl::string manifest_base_url() const { return manifest_base_url_; }
- void set_manifest_base_url(nacl::string url) { manifest_base_url_ = url; }
+ void set_manifest_base_url(const nacl::string& url) {
+ manifest_base_url_ = url;
+ }
// The URL of the manifest file as set by the "src" attribute.
// It is not the fully resolved URL if it was set as relative.
« no previous file with comments | « content/renderer/renderer_main_platform_delegate_win.cc ('k') | ppapi/native_client/src/trusted/plugin/service_runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698