Fix two unchecked return values

Fix two unchecked return values

CID=104234,104664
BUG=
TEST=

Committed as http://src.chromium.org/viewvc/chrome?view=rev&revision=149970

[brettw, 2012-07-26 17:38:04]

+ericu to check return value listed below.

http://codereview.chromium.org/10824031/diff/6001/webkit/fileapi/file_system_...
File webkit/fileapi/file_system_usage_cache.cc (right):

http://codereview.chromium.org/10824031/diff/6001/webkit/fileapi/file_system_...
webkit/fileapi/file_system_usage_cache.cc:92: return true;
I'm not 100% sure if this is correct. Let's ask Eric

[ericu, 2012-07-26 17:58:52]

http://codereview.chromium.org/10824031/diff/6001/webkit/fileapi/file_system_...
File webkit/fileapi/file_system_usage_cache.cc (right):

http://codereview.chromium.org/10824031/diff/6001/webkit/fileapi/file_system_...
webkit/fileapi/file_system_usage_cache.cc:92: return true;
On 2012/07/26 17:38:04, brettw wrote:
> I'm not 100% sure if this is correct. Let's ask Eric

I think we want to return false there, but Kinuko or DMikurube would know for
sure.

[kinuko, 2012-07-26 18:45:30]

http://codereview.chromium.org/10824031/diff/6001/webkit/fileapi/file_system_...
File webkit/fileapi/file_system_usage_cache.cc (right):

http://codereview.chromium.org/10824031/diff/6001/webkit/fileapi/file_system_...
webkit/fileapi/file_system_usage_cache.cc:92: return true;
On 2012/07/26 17:58:52, ericu wrote:
> On 2012/07/26 17:38:04, brettw wrote:
> > I'm not 100% sure if this is correct. Let's ask Eric
> 
> I think we want to return false there, but Kinuko or DMikurube would know for
> sure.

Looks like this should return false.  dmikurube@ can you confirm?

[Tyler Breisacher (Chromium), 2012-07-26 18:47:07]

http://codereview.chromium.org/10824031/diff/6001/webkit/fileapi/file_system_...
File webkit/fileapi/file_system_usage_cache.cc (right):

http://codereview.chromium.org/10824031/diff/6001/webkit/fileapi/file_system_...
webkit/fileapi/file_system_usage_cache.cc:92: return true;
If I'm not mistaken it's currently returning true, because we init is_valid to
true at the top. So it looks like Coverity may have helped us find an actual
bug. Hooray!

[Dai Mikurube (NOT FULLTIME), 2012-07-27 03:53:42]

http://codereview.chromium.org/10824031/diff/6001/webkit/fileapi/file_system_...
File webkit/fileapi/file_system_usage_cache.cc (right):

http://codereview.chromium.org/10824031/diff/6001/webkit/fileapi/file_system_...
webkit/fileapi/file_system_usage_cache.cc:92: return true;
On 2012/07/26 18:47:07, Tyler Breisacher wrote:
> If I'm not mistaken it's currently returning true, because we init is_valid to
> true at the top. So it looks like Coverity may have helped us find an actual
> bug. Hooray!

I think false is fine here.

[Tyler Breisacher (Chromium), 2012-08-03 18:16:38]

On 2012/07/27 03:53:42, Dai Mikurube wrote:
>
> I think false is fine here.

Done

[kinuko, 2012-08-03 22:18:10]

On 2012/08/03 18:16:38, Tyler Breisacher wrote:
> On 2012/07/27 03:53:42, Dai Mikurube wrote:
> >
> > I think false is fine here.
> 
> Done

lgtm thanks for catching this!

[commit-bot: I haz the power, 2012-08-03 22:20:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/10824031/9001

[commit-bot: I haz the power, 2012-08-03 23:34:36]

Failed to request the patch to try. Please note that binary filesare still
unsupported at the moment, this is being worked on.

Thanks for your patience.

HTTP Error 500: <h1>500 Server Error</h1>

[commit-bot: I haz the power, 2012-08-03 23:34:48]

Commit queue had an internal error.
Something went really wrong, probably a crash, a hickup or
simply the monkeys went out for dinner.
The relevant dude was pinged already.

[commit-bot: I haz the power, 2012-08-06 16:20:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/10824031/9001

[commit-bot: I haz the power, 2012-08-06 16:20:22]

Failed to apply patch for webkit/fileapi/file_system_usage_cache.cc:
While running patch -p1 --forward --force;
patching file webkit/fileapi/file_system_usage_cache.cc
Hunk #1 FAILED at 86.
Hunk #2 FAILED at 163.
2 out of 2 hunks FAILED -- saving rejects to file
webkit/fileapi/file_system_usage_cache.cc.rej