Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4286)

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_popup_controller.h

Issue 10824030: Move ExtensionHost into extensions namespace (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/extension_popup_controller.h
diff --git a/chrome/browser/ui/cocoa/extensions/extension_popup_controller.h b/chrome/browser/ui/cocoa/extensions/extension_popup_controller.h
index fc3c536970a9d8ad1b8446f1704e07cd394eb6f2..10d456e3868c3281c379911c54e8a44abde88f4c 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_popup_controller.h
+++ b/chrome/browser/ui/cocoa/extensions/extension_popup_controller.h
@@ -17,13 +17,16 @@
class Browser;
class DevtoolsNotificationBridge;
-class ExtensionHost;
class ExtensionPopupContainer;
namespace content {
class NotificationRegistrar;
}
+namespace extensions {
+class ExtensionHost;
+}
+
// This controller manages a single browser action popup that can appear once a
// user has clicked on a browser action button. It instantiates the extension
// popup view showing the content and resizes the window to accomodate any size
@@ -41,7 +44,7 @@ class NotificationRegistrar;
NSRect extensionFrame_;
// The extension host object.
- scoped_ptr<ExtensionHost> host_;
+ scoped_ptr<extensions::ExtensionHost> host_;
scoped_ptr<content::NotificationRegistrar> registrar_;
scoped_ptr<DevtoolsNotificationBridge> notificationBridge_;
@@ -54,8 +57,8 @@ class NotificationRegistrar;
NSSize pendingSize_;
}
-// Returns the ExtensionHost object associated with this popup.
-- (ExtensionHost*)extensionHost;
+// Returns the extensions::ExtensionHost object associated with this popup.
Peter Kasting 2012/07/26 18:13:48 Nit: The qualifier here seems to slightly decrease
+- (extensions::ExtensionHost*)extensionHost;
// Starts the process of showing the given popup URL. Instantiates an
// ExtensionPopupController with the parent window retrieved from |browser|, a

Powered by Google App Engine
This is Rietveld 408576698