Move ExtensionHost into extensions namespace

Move ExtensionHost into extensions namespace

BUG=139042, 117261
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149295

[Devlin, 2012-07-26 18:07:32]

Refactor; please review when time allows.
pkasting - c/b/ui
yoshiki  - c/b/task_manager
jochen   - c/b/content_settings
satish   - c/b/speech
atwilson - c/b/background
kalman   - c/b/extensions

[Peter Kasting, 2012-07-26 18:13:47]

OWNERS LGTM

https://chromiumcodereview.appspot.com/10824030/diff/1001/chrome/browser/ui/c...
File chrome/browser/ui/cocoa/extensions/extension_popup_controller.h (right):

https://chromiumcodereview.appspot.com/10824030/diff/1001/chrome/browser/ui/c...
chrome/browser/ui/cocoa/extensions/extension_popup_controller.h:60: // Returns
the extensions::ExtensionHost object associated with this popup.
Nit: The qualifier here seems to slightly decrease readability

https://chromiumcodereview.appspot.com/10824030/diff/1001/chrome/browser/ui/c...
File chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm (right):

https://chromiumcodereview.appspot.com/10824030/diff/1001/chrome/browser/ui/c...
chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm:24: using
extensions::ExtensionHost;
Nit: Don't do this -- we try to avoid using statements, except for things from
content, where the owners are trying to do a different pattern.

https://chromiumcodereview.appspot.com/10824030/diff/1001/chrome/browser/ui/v...
File chrome/browser/ui/views/extensions/extension_dialog.cc (right):

https://chromiumcodereview.appspot.com/10824030/diff/1001/chrome/browser/ui/v...
chrome/browser/ui/views/extensions/extension_dialog.cc:29: using
extensions::ExtensionHost;
Nit: Another using statement

[Andrew T Wilson (Slow), 2012-07-26 20:58:01]

background LGTM

[jochen (gone - plz use gerrit), 2012-07-26 21:06:09]

content settings LGTM

[not at google - send to devlin, 2012-07-27 01:23:24]

extensions lgtm

I think using extensions::ExtensionHost is fine within extensions code since
it's all going to be moved inside the extensions namespace eventually.

https://chromiumcodereview.appspot.com/10824030/diff/1001/chrome/browser/exte...
File chrome/browser/extensions/extension_host.cc (right):

https://chromiumcodereview.appspot.com/10824030/diff/1001/chrome/browser/exte...
chrome/browser/extensions/extension_host.cc:279: if (extension_ ==
content::Details<UnloadedExtensionInfo>(details)->
nit: keep line break after the ==

[Peter Kasting, 2012-07-27 01:54:30]

I'm fine with using statements in files that will be moving into that namespace
themselves in a short time -- it's less disruptive, as long as it's a temporary
rather than permanent measure.

[yoshiki, 2012-07-27 11:19:49]

task_manager LGTM

[Devlin, 2012-07-31 18:00:37]

- satish (Busy? Vacation?)
+ hans
for c/b/speech

[hans, 2012-07-31 18:02:29]

On 2012/07/31 18:00:37, D Cronin wrote:
> - satish (Busy? Vacation?)
> + hans
> for c/b/speech

chrome/browser/speech LGTM

[commit-bot: I haz the power, 2012-07-31 19:57:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10824030/1...

[commit-bot: I haz the power, 2012-07-31 19:58:28]

Presubmit check for 10824030-10056 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome
    chrome/browser/automation

Presubmit checks took 5.0s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[Devlin, 2012-07-31 20:05:28]

+ jam for automation and chrome
jam: I know we can TBR for gypi changes for chrome/; can we do the same for
refactors?

[jam, 2012-07-31 21:02:07]

On 2012/07/31 20:05:28, D Cronin wrote:
> + jam for automation and chrome
> jam: I know we can TBR for gypi changes for chrome/; can we do the same for
> refactors?

yes, for moving code into namespace, tbr

rubberstamp lgtm

[commit-bot: I haz the power, 2012-07-31 21:08:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10824030/1...

[commit-bot: I haz the power, 2012-07-31 22:25:18]

Change committed as 149295