Issue 10824023: Revert "Revert 148383 - Move the keyboard overlay view to ash."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824023: Revert "Revert 148383 - Move the keyboard overlay view to ash." (Closed)

Created:
8 years, 5 months ago by mazda

Modified:
8 years, 5 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert "Revert 148383 - Move the keyboard overlay view to ash." The original CL broke win_aura, which is fixed in this CL. This reverts commit b36e66174d685a4195d7cc934d978086e033a8c4. TBR=ben@chromium.org BUG=124222 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148428

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+123 lines, -323 lines)			Patch
M	ash/DEPS	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/ash.gyp	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	ash/ash_strings.grd	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A +	ash/keyboard_overlay/keyboard_overlay_delegate.h	View	4 chunks	+8 lines, -4 lines	0 comments	Download
A +	ash/keyboard_overlay/keyboard_overlay_delegate.cc	View	4 chunks	+5 lines, -7 lines	0 comments	Download
A	ash/keyboard_overlay/keyboard_overlay_view.h	View	1 chunk	+42 lines, -0 lines	0 comments	Download
A	ash/keyboard_overlay/keyboard_overlay_view.cc	View	1 chunk	+52 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/ash/chrome_shell_delegate.cc	View	3 chunks	+6 lines, -2 lines	0 comments	Download
D	chrome/browser/ui/views/keyboard_overlay_delegate.h	View	1 chunk	+0 lines, -52 lines	0 comments	Download
D	chrome/browser/ui/views/keyboard_overlay_delegate.cc	View	1 chunk	+0 lines, -145 lines	0 comments	Download
D	chrome/browser/ui/views/keyboard_overlay_dialog_view.h	View	1 chunk	+0 lines, -38 lines	0 comments	Download
D	chrome/browser/ui/views/keyboard_overlay_dialog_view.cc	View	1 chunk	+0 lines, -65 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	3 chunks	+0 lines, -10 lines	0 comments	Download

Total messages: 2 (0 generated)

mazda

TBRing as the change from http://crrev.com/148383 is only adding web_dialog dependency to ash.gyp.

8 years, 5 months ago (2012-07-25 21:55:21 UTC) #1

lgtm