Callback flow to register Chrome and update shortcuts after OS upgrade to Windows 8

chrome/installer/setup/install.cc

Index: chrome/installer/setup/install.cc
diff --git a/chrome/installer/setup/install.cc b/chrome/installer/setup/install.cc
index bd7ab6ff49ef95e607eb51f31d95e09e4a8cae39..e4aed9c389d484cb960dd30a64d38b0bb2b5c183 100644
--- a/chrome/installer/setup/install.cc
+++ b/chrome/installer/setup/install.cc
@@ -552,4 +552,21 @@ InstallStatus InstallOrUpdateProduct(
   return result;
 }
 
+bool HandleOsUpgradeForBrowser(const InstallerState& installer_state,

[gab, 2012/08/30 17:55:19]

I thought I'd mentioned this before (maybe it argued against and I missed it?):

You only return true from here so the return value is rather useless.

You can either:

1) make the shortcuts function return a bool and then return true if they all
passed (they already have failure logs they just don't return their success as
it is now).

2) simply return void.

I prefer (1).

[huangs, 2012/08/30 20:14:22]

Done.  I chased after error messages.  Avoided changing control flow (so store
in "is_successful" variable instead of early "return false;").  Also, other
callers of the Shortcut routines ignore the return values.

+                               const Product& chrome_install,

[grt (UTC plus 2), 2012/08/30 19:10:18]

chrome_install -> chrome

[huangs, 2012/08/30 20:14:22]

Done.

+                               const FilePath& setup_exe) {
+  // Upon upgrading to Windows 8, we need to fix Chrome shortcuts and register

[grt (UTC plus 2), 2012/08/30 19:10:18]

DCHECK(chrome.is_chrome()); before this line

[huangs, 2012/08/30 20:14:22]

Done.

+  // Chrome, so that Metro Chrome would work if Chrome is the default browser.
+  if (base::win::GetVersion() >= base::win::VERSION_WIN8) {
+    VLOG(1) << "Updating and registering shortcuts.";
+    uint32 shortcut_options = ShellUtil::SHORTCUT_DUAL_MODE;
+    CreateOrUpdateDesktopAndQuickLaunchShortcuts(
+        installer_state, chrome_install, shortcut_options);
+    CreateOrUpdateStartMenuAndTaskbarShortcuts(
+        installer_state, setup_exe, chrome_install, shortcut_options);
+    RegisterChromeOnMachine(installer_state, chrome_install, false);
+  }
+  return true;
+}
+
 }  // namespace installer