Callback flow to register Chrome and update shortcuts after OS upgrade to Windows 8

chrome/installer/setup/uninstall.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file defines the methods useful for uninstalling Chrome.
 
 #include "chrome/installer/setup/uninstall.h"
 
 #include <windows.h>
 
@@ skipping 109 matching lines @@
             << " is somehow already set to the desired new value of "
             << channel_info.value();
       }
     }
 
     bool success = update_list->Do();
     LOG_IF(ERROR, !success) << "Failed updating channel values.";
   }
 }
 
+void ProcessOnOsUpgradeWorkItems(
+    const installer::InstallerState& installer_state,
+    const installer::Product& product) {
+  scoped_ptr<WorkItemList> work_item_list(
+      WorkItem::CreateNoRollbackWorkItemList());
+  AddOsUpgradeWorkItems(installer_state, NULL, NULL, product,

[gab, 2012/08/30 20:26:28]

Arg... I hate this... ok sure use a pointer... but this needs to get better in
your future refactoring CL.

[huangs, 2012/08/30 20:46:31]

Acknowledged.

+                        work_item_list.get());
+  if (!work_item_list->Do())
+    LOG(ERROR) << "Failed to remove on-os-upgrade command.";
+}
+
 // Adds or removes the quick-enable-cf command to the binaries' version key in
 // the registry as needed.
 void ProcessQuickEnableWorkItems(
     const installer::InstallerState& installer_state,
     const installer::InstallationState& machine_state) {
   scoped_ptr<WorkItemList> work_item_list(
       WorkItem::CreateNoRollbackWorkItemList());
 
   AddQuickEnableChromeFrameWorkItems(installer_state, machine_state, NULL, NULL,
                                      work_item_list.get());
@@ skipping 919 matching lines @@
     if (installer_state.system_install() ||
         (remove_all &&
          ShellUtil::QuickIsChromeRegisteredInHKLM(
              browser_dist, chrome_exe, suffix))) {
       DeleteChromeRegistrationKeys(browser_dist, HKEY_LOCAL_MACHINE, suffix,
                                    installer_state.target_path(), &ret);
     }
 
     ProcessDelegateExecuteWorkItems(installer_state, product);
 
+    ProcessOnOsUpgradeWorkItems(installer_state, product);
+
 // TODO(gab): This is only disabled for M22 as the shortcut CL using Active
 // Setup will not make it in M22.
 #if 0
     UninstallActiveSetupEntries(installer_state, product);
 #endif
   }
 
   if (product.is_chrome_frame()) {
     ProcessChromeFrameWorkItems(original_state, installer_state, setup_path,
                                 product);
@@ skipping 101 matching lines @@
 
   // Try and delete the preserved local state once the post-install
   // operations are complete.
   if (!backup_state_file.empty())
     file_util::Delete(backup_state_file, false);
 
   return ret;
 }
 
 }  // namespace installer