Callback flow to register Chrome and update shortcuts after OS upgrade to Windows 8

chrome/installer/setup/install.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/installer/setup/install.h"
 
 #include <shlobj.h>
 #include <time.h>
 #include <winuser.h>
 
@@ skipping 238 matching lines @@
               << " to " << src_path.value();
       return true;
     } else {
       PLOG(ERROR) << "Error writing " << installer::kVisualElementsManifest
                   << " to " << src_path.value();
       return false;
     }
   }
 }
 
-void CreateOrUpdateStartMenuAndTaskbarShortcuts(
+bool CreateOrUpdateStartMenuAndTaskbarShortcuts(
     const InstallerState& installer_state,
     const FilePath& setup_exe,
     const Product& product,
     uint32 options) {
+  bool is_successful = true;

[gab, 2012/08/30 20:26:27]

nit: We try to avoid is_* in chromium. Please rename to "bool success" (if you
codesearch for one vs the other in quotes and you'll see a lot more instances of
"bool success").

[huangs, 2012/08/30 20:46:31]

Done.

   // TODO(tommi): Change this function to use WorkItemList.
   DCHECK(product.is_chrome());
 
   // Information used for all shortcut types
   BrowserDistribution* browser_dist = product.distribution();
   const string16 product_name(browser_dist->GetAppShortCutName());
   const string16 product_desc(browser_dist->GetAppDescription());
   // Chrome link target
   FilePath chrome_exe(
       installer_state.target_path().Append(installer::kChromeExe));
 
   bool create_always = ((options & ShellUtil::SHORTCUT_CREATE_ALWAYS) != 0);
   const char* operation = create_always ? "Creating" : "Updating";
 
   // Create Start Menu shortcuts.
   // The location of Start->Programs->Google Chrome folder
   FilePath start_menu_folder_path;
   int dir_enum = installer_state.system_install() ?
       base::DIR_COMMON_START_MENU : base::DIR_START_MENU;
   if (!PathService::Get(dir_enum, &start_menu_folder_path)) {
     LOG(ERROR) << "Failed to get start menu path.";
-    return;
+    return false;
   }
 
   start_menu_folder_path = start_menu_folder_path.Append(product_name);
 
   // Create/update Chrome link (points to chrome.exe) & Uninstall Chrome link
   // (which points to setup.exe) under |start_menu_folder_path|.
 
   // Chrome link (launches Chrome)
   FilePath chrome_link(start_menu_folder_path.Append(product_name + L".lnk"));
 
   if (create_always && !file_util::PathExists(start_menu_folder_path))
       file_util::CreateDirectoryW(start_menu_folder_path);
 
   VLOG(1) << operation << " shortcut to " << chrome_exe.value() << " at "
           << chrome_link.value();
   if (!ShellUtil::UpdateChromeShortcut(browser_dist, chrome_exe.value(),
           chrome_link.value(), string16(), product_desc, chrome_exe.value(),
           browser_dist->GetIconIndex(), options)) {
     LOG(WARNING) << operation << " shortcut at " << chrome_link.value()
                  << " failed.";
+    is_successful = false;
   } else if (create_always &&
              base::win::GetVersion() >= base::win::VERSION_WIN7) {
     // If the Start Menu shortcut was successfully created and |create_always|,
     // proceed to pin the Start Menu shortcut to the taskbar on Win7+.
     VLOG(1) << "Pinning new shortcut at " << chrome_link.value()
             << " to taskbar";
     if (!file_util::TaskbarPinShortcutLink(chrome_link.value().c_str())) {
       LOG(ERROR) << "Failed to pin shortcut to taskbar: "
                  << chrome_link.value();
     }
+    is_successful = false;
   }
 
   // Create/update uninstall link if we are not an MSI install. MSI
   // installations are, for the time being, managed only through the
   // Add/Remove Programs dialog.
   // TODO(robertshield): We could add a shortcut to msiexec /X {GUID} here.
   if (!installer_state.is_msi()) {
     // Uninstall Chrome link
     FilePath uninstall_link(start_menu_folder_path.Append(
         browser_dist->GetUninstallLinkName() + L".lnk"));
 
     CommandLine arguments(CommandLine::NO_PROGRAM);
     AppendUninstallCommandLineFlags(installer_state, product, &arguments);
     VLOG(1) << operation << " uninstall link at " << uninstall_link.value();
     if (!file_util::CreateOrUpdateShortcutLink(setup_exe.value().c_str(),
             uninstall_link.value().c_str(), NULL,
             arguments.GetCommandLineString().c_str(), NULL,
             setup_exe.value().c_str(), 0, NULL,
             create_always ? file_util::SHORTCUT_CREATE_ALWAYS :
                             file_util::SHORTCUT_NO_OPTIONS)) {
       LOG(WARNING) << operation << " uninstall link at "
                    << uninstall_link.value() << " failed.";
+      is_successful = false;
     }
   }
+  return is_successful;
 }
 
-void CreateOrUpdateDesktopAndQuickLaunchShortcuts(
+bool CreateOrUpdateDesktopAndQuickLaunchShortcuts(
     const InstallerState& installer_state,
     const Product& product,
     uint32 options) {
+  bool is_successful = true;

[gab, 2012/08/30 20:26:28]

nit: same here

[huangs, 2012/08/30 20:46:31]

Done.

   // TODO(tommi): Change this function to use WorkItemList.
   DCHECK(product.is_chrome());
 
   // Information used for all shortcut types
   BrowserDistribution* browser_dist = product.distribution();
   const string16 product_name(browser_dist->GetAppShortCutName());
   const string16 product_desc(browser_dist->GetAppDescription());
   // Chrome link target
   FilePath chrome_exe(
       installer_state.target_path().Append(installer::kChromeExe));
 
   bool create_always = ((options & ShellUtil::SHORTCUT_CREATE_ALWAYS) != 0);
   const char* operation = create_always ? "Creating" : "Updating";
 
   ShellUtil::ShellChange desktop_level = ShellUtil::CURRENT_USER;
   int quick_launch_levels = ShellUtil::CURRENT_USER;
   if (installer_state.system_install()) {
     desktop_level = ShellUtil::SYSTEM_LEVEL;
     quick_launch_levels |= ShellUtil::SYSTEM_LEVEL;
   }
 
   VLOG(1) << operation << " desktop shortcut for " << chrome_exe.value();
   if (!ShellUtil::CreateChromeDesktopShortcut(
           browser_dist, chrome_exe.value(), product_desc, string16(),
           string16(), chrome_exe.value(), browser_dist->GetIconIndex(),
           desktop_level, options)) {
     LOG(WARNING) << operation << " desktop shortcut for " << chrome_exe.value()
                  << " failed.";
+    is_successful = false;
   }
 
   VLOG(1) << operation << " quick launch shortcut for " << chrome_exe.value();
   if (!ShellUtil::CreateChromeQuickLaunchShortcut(
           browser_dist, chrome_exe.value(), quick_launch_levels, options)) {
     LOG(WARNING) << operation << " quick launch shortcut for "
                  << chrome_exe.value() << " failed.";
+    is_successful = false;
   }
+  return is_successful;
 }
 
 void RegisterChromeOnMachine(const InstallerState& installer_state,
                              const Product& product,
                              bool make_chrome_default) {
   DCHECK(product.is_chrome());
 
   // Try to add Chrome to Media Player shim inclusion list. We don't do any
   // error checking here because this operation will fail if user doesn't
   // have admin rights and we want to ignore the error.
@@ skipping 153 matching lines @@
 
     installer_state.RemoveOldVersionDirectories(
         new_version,
         existing_version.get(),
         install_temp_path);
   }
 
   return result;
 }
 
+bool HandleOsUpgradeForBrowser(const InstallerState& installer_state,
+                               const Product& chrome,
+                               const FilePath& setup_exe) {
+  DCHECK(chrome.is_chrome());
+  bool is_successful = true;

[gab, 2012/08/30 20:26:28]

nit: and here

[huangs, 2012/08/30 20:46:31]

Done.

+  // Upon upgrading to Windows 8, we need to fix Chrome shortcuts and register
+  // Chrome, so that Metro Chrome would work if Chrome is the default browser.
+  if (base::win::GetVersion() >= base::win::VERSION_WIN8) {
+    VLOG(1) << "Updating and registering shortcuts.";
+    uint32 shortcut_options = ShellUtil::SHORTCUT_DUAL_MODE;
+    if (!CreateOrUpdateDesktopAndQuickLaunchShortcuts(
+        installer_state, chrome, shortcut_options)) {
+      is_successful = false;
+    }
+    if (!CreateOrUpdateStartMenuAndTaskbarShortcuts(

[gab, 2012/08/30 20:26:28]

Unify the ifs, i.e. if (!1 || !2 || !3) {}

[huangs, 2012/08/30 20:46:31]

Discussed: Doing success = fun() && success; instead.

+        installer_state, setup_exe, chrome, shortcut_options)) {
+      is_successful = false;
+    }
+    RegisterChromeOnMachine(installer_state, chrome, false);

[gab, 2012/08/30 20:26:28]

Add this call to the list of possible failures too.

+  }
+  return is_successful;
+}
+
 }  // namespace installer