Callback flow to register Chrome and update shortcuts after OS upgrade to Windows 8

chrome/installer/util/installation_validator_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <map>
 
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
@@ skipping 67 matching lines @@
                            const char* version,
                            int channel_modifiers,
                            Vehicle vehicle);
   void AddQuickEnableApplicationHostCommand(BrowserDistribution::Type dist_type,
                                             Level install_level,
                                             const char* version,
                                             int channel_modifiers);
   void AddQuickEnableCfCommand(BrowserDistribution::Type dist_type,
                                Level install_level,
                                const char* version,
                                int channel_modifiers);

[huangs, 2012/08/31 20:50:17]

Need to declare
  void AddOsUpgradeCommand(...);
here.

   void set_multi_install(bool is_multi_install) {
     multi_install_ = is_multi_install;
   }
   installer::AppCommands& commands() { return commands_; }
 
  protected:
   struct ChannelMethodForModifier {
     ChannelModifier modifier;
     bool (ChannelInfo::*method)(bool value);
   };
@@ skipping 104 matching lines @@
     Level install_level,
     const char* version,
     int channel_modifiers) {
   DCHECK_EQ(dist_type, BrowserDistribution::CHROME_BINARIES);
   DCHECK_NE(channel_modifiers & CM_MULTI, 0);
 
   CommandLine cmd_line(GetSetupExePath(dist_type, install_level, version,
                                        channel_modifiers));
   cmd_line.AppendSwitch(installer::switches::kMultiInstall);
   cmd_line.AppendSwitch(installer::switches::kChromeAppHost);
-  commands_.Set(installer::kCmdQuickEnableApplicationHost,
-                AppCommand(cmd_line.GetCommandLineString(), true, true));
+  AppCommand app_cmd(cmd_line.GetCommandLineString());
+  app_cmd.set_sends_pings(true);
+  app_cmd.set_is_web_accessible(true);
+  commands_.Set(installer::kCmdQuickEnableApplicationHost, app_cmd);
 }
 
 // Adds the "quick-enable-cf" Google Update product command.
 void FakeProductState::AddQuickEnableCfCommand(
     BrowserDistribution::Type dist_type,
     Level install_level,
     const char* version,
     int channel_modifiers) {
   DCHECK_EQ(dist_type, BrowserDistribution::CHROME_BINARIES);
   DCHECK_NE(channel_modifiers & CM_MULTI, 0);
 
   CommandLine cmd_line(GetSetupExePath(dist_type, install_level, version,
                                        channel_modifiers));
   cmd_line.AppendSwitch(installer::switches::kMultiInstall);
   if (install_level == SYSTEM_LEVEL)
     cmd_line.AppendSwitch(installer::switches::kSystemLevel);
   cmd_line.AppendSwitch(installer::switches::kChromeFrameQuickEnable);
-  commands_.Set(installer::kCmdQuickEnableCf,
-                AppCommand(cmd_line.GetCommandLineString(), true, true));
+  AppCommand app_cmd(cmd_line.GetCommandLineString());
+  app_cmd.set_sends_pings(true);
+  app_cmd.set_is_web_accessible(true);
+  commands_.Set(installer::kCmdQuickEnableCf, app_cmd);
 }

[huangs, 2012/08/31 20:50:17]

Need to implement
void FakeProductState::AddOsUpgradeCommand(...){}
here.

 
 }  // namespace
 
 // Fixture for testing the InstallationValidator.  Errors logged by the
 // validator are sent to an optional mock recipient (see
 // set_validation_error_recipient) upon which expectations can be placed.
 class InstallationValidatorTest
     : public testing::TestWithParam<InstallationValidator::InstallationType> {
  public:
 
@@ skipping 177 matching lines @@
        inst_type ==
            InstallationValidator::CHROME_FRAME_READY_MODE_CHROME_MULTI)) {
     state->AddQuickEnableCfCommand(prod_type, install_level,
                                    chrome::kChromeVersion, channel_modifiers);
   }
   if (prod_type == BrowserDistribution::CHROME_BINARIES) {
     state->AddQuickEnableApplicationHostCommand(prod_type,
                                                 install_level,
                                                 chrome::kChromeVersion,
                                                 channel_modifiers);
   }

[huangs, 2012/08/31 20:50:17]

Need to call state->AddOsUpgradeCommand(...) here, if CHROME_BROWSER.

 }
 
 // static
 // Populates |state| with the state of a valid installation of |inst_type|.
 void InstallationValidatorTest::MakeMachineState(
     InstallationValidator::InstallationType inst_type,
     Level install_level,
     Channel channel,
     Vehicle vehicle,
     FakeInstallationState* state) {
@@ skipping 61 matching lines @@
     InstallationValidatorTest,
     Values(InstallationValidator::NO_PRODUCTS,
            InstallationValidator::CHROME_SINGLE,
            InstallationValidator::CHROME_MULTI,
            InstallationValidator::CHROME_FRAME_SINGLE,
            InstallationValidator::CHROME_FRAME_SINGLE_CHROME_SINGLE,
            InstallationValidator::CHROME_FRAME_SINGLE_CHROME_MULTI,
            InstallationValidator::CHROME_FRAME_MULTI,
            InstallationValidator::CHROME_FRAME_MULTI_CHROME_MULTI,
            InstallationValidator::CHROME_FRAME_READY_MODE_CHROME_MULTI));