Callback flow to register Chrome and update shortcuts after OS upgrade to Windows 8

chrome/installer/setup/setup_main.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <windows.h>
 #include <msi.h>
 #include <shellapi.h>
 #include <shlobj.h>
 
 #include "base/at_exit.h"
@@ skipping 1152 matching lines @@
     }
     installer::InstallStatus tmp = installer::UNKNOWN_STATUS;
     const Product* chrome_install =
         installer_state->FindProduct(BrowserDistribution::CHROME_BROWSER);
     DCHECK(chrome_install);
     if (chrome_install) {
       installer::DeleteChromeRegistrationKeys(chrome_install->distribution(),
           HKEY_LOCAL_MACHINE, suffix, installer_state->target_path(), &tmp);
     }
     *exit_code = tmp;
+  } else if (cmd_line.HasSwitch(installer::switches::kOnOsUpgrade)) {
+    const Product* chrome_install =
+        installer_state->FindProduct(BrowserDistribution::CHROME_BROWSER);
+    if (chrome_install) {
+      if (installer::HandleOsUpgradeForBrowser(*installer_state,

[gab, 2012/08/30 17:55:19]

Instead of using a double if with the same else block, use if (x && y) {} else
{}

[huangs, 2012/08/30 20:14:22]

Done.

+                                               *chrome_install,
+                                               cmd_line.GetProgram())) {
+        *exit_code = 0;  // Success.
+      } else {
+        *exit_code = installer::UNKNOWN_STATUS;

[grt (UTC plus 2), 2012/08/30 19:10:18]

aaah.  now i see why you wanted to add a new InstallStatus.  if you choose to
keep HandleOsUpgradeForBrowser returning bool, please hit me with a wet noodle
and re-add the InstallStatus.

[huangs, 2012/08/30 20:14:22]

Discussed with gab.  Now adding installer::HANDLE_OS_UPGRADE_FAILED flag, and on
success, will return installer::INSTALL_REPAIRED  (this imitates the behaviour
of ChromeFrameReadyModeEndTempOptOut().

+      }
+    } else {
+      *exit_code = installer::UNKNOWN_STATUS;
+    }
   } else if (cmd_line.HasSwitch(installer::switches::kInactiveUserToast)) {
     // Launch the inactive user toast experiment.
     int flavor = -1;
     base::StringToInt(cmd_line.GetSwitchValueNative(
         installer::switches::kInactiveUserToast), &flavor);
     std::string experiment_group =
         cmd_line.GetSwitchValueASCII(installer::switches::kExperimentGroup);
     DCHECK_NE(-1, flavor);
     if (flavor == -1) {
       *exit_code = installer::UNKNOWN_STATUS;
@@ skipping 316 matching lines @@
   if (!(installer_state.is_msi() && is_uninstall))
     // Note that we allow the status installer::UNINSTALL_REQUIRES_REBOOT
     // to pass through, since this is only returned on uninstall which is
     // never invoked directly by Google Update.
     return_code = InstallUtil::GetInstallReturnCode(install_status);
 
   VLOG(1) << "Installation complete, returning: " << return_code;
 
   return return_code;
 }