Callback flow to register Chrome and update shortcuts after OS upgrade to Windows 8

chrome/installer/setup/install_worker.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file contains the declarations of the installer functions that build
 // the WorkItemList used to install the application.
 
 #ifndef CHROME_INSTALLER_SETUP_INSTALL_WORKER_H_
 #define CHROME_INSTALLER_SETUP_INSTALL_WORKER_H_
 
@@ skipping 183 matching lines @@
 // the executable currently being run) and |new_version| (the version of the
 // product(s) currently being installed) are required when processing product
 // installation; they are unused (and may therefore be NULL) when uninstalling.
 void AddQuickEnableApplicationHostWorkItems(
     const InstallerState& installer_state,
     const InstallationState& machine_state,
     const FilePath* setup_path,
     const Version* new_version,
     WorkItemList* work_item_list);
 
+// Add work items to add or remove the "on-os-upgrade" command to |product|'s

[grt (UTC plus 2), 2012/08/30 04:15:25]

"Add" -> "Adds"

[huangs, 2012/08/30 17:13:07]

Done, also fixed for three other methods.

+// version key on the basis of the current operation (represented in
+// |installer_state|).  |setup_path| (the path to the executable
+// currently being run) and |new_version| (the version of the product(s)
+// currently being installed) are required when processing product
+// installation; they are unused (and may therefore be NULL) when uninstalling.
+void AddOsUpgradeWorkItems(const InstallerState& installer_state,
+                           const FilePath* setup_path,
+                           const Version* new_version,

[gab, 2012/08/30 14:24:32]

Don't pass a pointer just for the sake of being able to pass NULL. In Chromium
style, passing a pointer means you need to modify the object.
Make this a const& instead and pass in an empty version on uninstall (I'm pretty
sure this is what other calls like AddActiveSetupWorkItems() do).

[huangs, 2012/08/30 17:13:07]

Not fixing this yet, per discussion.  Will file cleanup bug.

+                           const Product& product,
+                           WorkItemList* install_list);
+
 }  // namespace installer
 
 #endif  // CHROME_INSTALLER_SETUP_INSTALL_WORKER_H_