Callback flow to register Chrome and update shortcuts after OS upgrade to Windows 8

chrome/installer/setup/install.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/installer/setup/install.h"
 
 #include <shlobj.h>
 #include <time.h>
 #include <winuser.h>
 
@@ skipping 534 matching lines @@
 
     installer_state.RemoveOldVersionDirectories(
         new_version,
         existing_version.get(),
         install_temp_path);
   }
 
   return result;
 }
 
+bool OnOsUpgrade(const InstallationState& original_state,
+                 const InstallerState& installer_state,
+                 const FilePath& setup_exe) {
+  const Product* chrome_install =
+      installer_state.FindProduct(BrowserDistribution::CHROME_BROWSER);
+  DCHECK(chrome_install);

[grt (UTC plus 2), 2012/08/30 04:15:25]

if (!chrome_install) {
  NOTREACHED();
  return false;
}

[huangs, 2012/08/30 17:13:07]

No longer need this, as we'll pass Product& chrome_install from caller.

+
+  // Upon upgrading to Windows 8, we need to fix Chrome shortcuts and register
+  // Chrome, so that Metro Chrome would work if Chrome is the default browser.
+  if (base::win::GetVersion() >= base::win::VERSION_WIN8) {
+    VLOG(1) << "Updating and registering shortcut for Windows 8.";

[grt (UTC plus 2), 2012/08/30 04:15:25]

"shortcut" -> "shortcuts"
and remove "Windows 8" since this will be called for Win11, too.

[huangs, 2012/08/30 17:13:07]

Done.

+    uint32 shortcut_options = ShellUtil::SHORTCUT_DUAL_MODE;
+    CreateOrUpdateDesktopAndQuickLaunchShortcuts(
+        installer_state, *chrome_install, shortcut_options);
+    CreateOrUpdateStartMenuAndTaskbarShortcuts(
+        installer_state, setup_exe, *chrome_install, shortcut_options);
+    RegisterChromeOnMachine(installer_state, *chrome_install, false);
+    SHChangeNotify(SHCNE_ASSOCCHANGED, SHCNF_IDLIST, NULL, NULL);

[gab, 2012/08/30 14:24:32]

You should not need to SHChangeNotify, the shortcut update code already takes
care of that (I know I suggested doing it here at top-level, as a test to see if
something weird was happening, but I recall you saying that wasn't it).

[huangs, 2012/08/30 17:13:07]

Done.

+  }
+  return true;
+}
+
 }  // namespace installer