Callback flow to register Chrome and update shortcuts after OS upgrade to Windows 8

chrome/installer/util/installation_validator.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_INSTALLER_UTIL_INSTALLATION_VALIDATOR_H_
 #define CHROME_INSTALLER_UTIL_INSTALLATION_VALIDATOR_H_
 
 #include <map>
 #include <string>
 #include <utility>
@@ skipping 178 matching lines @@
     virtual bool UsageStatsAllowed(
         const ProductState& product_state) const OVERRIDE;
   };
 
   struct ProductContext {
     const InstallationState& machine_state;
     bool system_install;
     BrowserDistribution* dist;
     const ProductState& state;
     const ProductRules& rules;
+
+    ProductContext(const InstallationState& machine_state,
+                   const bool system_install,
+                   const ProductState& state,
+                   const ProductRules& rules):

[gab, 2012/08/28 16:08:19]

See style at
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Class_...

1) Constructor at top
2) Colon on first initializer line

[huangs, 2012/08/29 17:02:54]

Done.

+        machine_state(machine_state),

[gab, 2012/08/28 16:08:19]

I don't know what the style is here, but I don't like that the variables and
parameters have the same name...

[gab, 2012/08/28 17:48:09]

Discussed with Erik and Greg, suffix all the parameters with "_in".

[grt (UTC plus 2), 2012/08/28 19:35:40]

+1.

[huangs, 2012/08/29 17:02:54]

Done.

+        system_install(system_install),
+        dist(BrowserDistribution::GetSpecificDistribution(
+            rules.distribution_type())),
+        state(state),
+        rules(rules) {
+    }
   };
 
+  static void ValidateOnOsUpgradeCommand(const ProductContext& ctx,
+                                         const AppCommand& command,
+                                         bool* is_valid);
   static void ValidateInstallAppCommand(const ProductContext& ctx,
-                                           const AppCommand& command,
-                                           bool* is_valid);
+                                        const AppCommand& command,
+                                        bool* is_valid);
   static void ValidateQuickEnableCfCommand(const ProductContext& ctx,
                                            const AppCommand& command,
                                            bool* is_valid);
   static void ValidateQuickEnableApplicationHostCommand(
     const ProductContext& ctx,
     const AppCommand& command,
     bool* is_valid);
 
   static void ValidateAppCommandExpectations(
       const ProductContext& ctx,
@@ skipping 21 matching lines @@
   static void ValidateRenameCommand(const ProductContext& ctx,
                                     bool* is_valid);
   static void ValidateOldVersionValues(const ProductContext& ctx,
                                        bool* is_valid);
   static void ValidateMultiInstallProduct(const ProductContext& ctx,
                                           bool* is_valid);
   static void ValidateAppCommands(const ProductContext& ctx,
                                   bool* is_valid);
   static void ValidateUsageStats(const ProductContext& ctx,
                                  bool* is_valid);
-  static void ValidateProduct(const InstallationState& machine_state,
-                              bool system_install,
-                              const ProductState& product_state,
-                              const ProductRules& rules,
+  static void ValidateProduct(const ProductContext& ctx,
                               bool* is_valid);
 
   // A collection of all valid installation types.
   static const InstallationType kInstallationTypes[];
 
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(InstallationValidator);
 };
 
 }  // namespace installer
 
 #endif  // CHROME_INSTALLER_UTIL_INSTALLATION_VALIDATOR_H_