Callback flow to register Chrome and update shortcuts after OS upgrade to Windows 8

chrome/installer/util/app_command.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_INSTALLER_UTIL_APP_COMMAND_H_
 #define CHROME_INSTALLER_UTIL_APP_COMMAND_H_
 
 #include <windows.h>
 
 #include <string>
 
 class WorkItemList;
 
 namespace base {
 namespace win {
 class RegKey;
 }
 }
 
 namespace installer {
 
 // A description of a command registered by setup.exe that can be invoked by
 // Google Update.  This class is CopyConstructible and Assignable for use in
 // STL containers.
 class AppCommand {
  public:
   AppCommand();
   AppCommand(const std::wstring& command_line, bool send_pings,

[gab, 2012/08/28 16:08:19]

Use string16 instead of std::wstring (or presubmit will fail when committing)...
this implies you have to include "base/string16.h" and since I don't generally
like to include both <string> and string16.h that means I'd like you to change
all std::wstring to string16's in this file (I've done most of them in the
installer already as part of other CLs, but looks like app_command.h is behind).

[grt (UTC plus 2), 2012/08/28 19:35:40]

since the command line is the only mandatory property of an app command, i
suggest replacing these two many-arg ctors with one that takes only the command
line.  callers can then set only those bool attributes they care about.  the
callsites will be more readable in this case since the reader won't need to know
what AppCommand(cmd_line, true, false, false) means.

[huangs, 2012/08/29 17:02:54]

Done (std::wstring --> string16).

[huangs, 2012/08/29 17:02:54]

Done (simplifying constructor; changed callers to use setters after
construction).

+             bool is_web_accessible, bool is_auto_run_on_os_upgrade);

[gab, 2012/08/28 16:08:19]

Why do you need anything, but |is_auto_run_on_os_upgrade| here? How are
|send_pings| and |is_web_accessible| relevant?

[huangs, 2012/08/29 17:02:54]

Made changes suggested by grt@.

+  // Ctor for code that don't use is_auto_run_on_os_upgrade.
+  AppCommand(const std::wstring& command_line, bool send_pings,
              bool is_web_accessible);
   // The implicit dtor, copy ctor and assignment operator are desired.
 
   // Initializes an instance from the command in |key|.
   bool Initialize(const base::win::RegKey& key);
 
   // Adds to |item_list| work items to write this object to the key named
   // |command_path| under |predefined_root|.
   void AddWorkItems(HKEY predefined_root,
                     const std::wstring& command_path,
                     WorkItemList* item_list) const;
 
   // Returns the command-line for the app command as it is represented in the
   // registry.  Use CommandLine::FromString() on this value to check arguments
   // or to launch the command.
   const std::wstring& command_line() const { return command_line_; }
   void set_command_line(const std::wstring& command_line) {
     command_line_ = command_line;
   }
 
   bool sends_pings() const { return sends_pings_; }
   void set_sends_pings(bool sends_pings) { sends_pings_ = sends_pings; }
 
   bool is_web_accessible() const { return is_web_accessible_; }
   void set_is_web_accessible(bool is_web_accessible) {
     is_web_accessible_ = is_web_accessible;
   }
 
+  bool is_auto_run_on_os_upgrade() const { return is_auto_run_on_os_upgrade_; }
+  void set_is_auto_run_on_os_upgrade(bool is_auto_run_on_os_upgrade) {
+    is_auto_run_on_os_upgrade_ = is_auto_run_on_os_upgrade;
+  }
+
  protected:
   std::wstring command_line_;
   bool sends_pings_;
   bool is_web_accessible_;
+  bool is_auto_run_on_os_upgrade_;
 };
 
 }  // namespace installer
 
 #endif  // CHROME_INSTALLER_UTIL_APP_COMMAND_H_