Fix the gdb path for NDK-r8b.

content/shell/content_shell_ant_helper.sh

 #!/bin/sh
 
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 set -eu
 
 # A helper script to help convert the values of the fifth parameter for

[Peter Beverloo, 2012/08/23 10:45:48]

fifth -> last?

 # ant building: 'Debug' -> 'debug'; 'Release' -> 'release'.
 # It's used by content/content_shell.gypi
 
-buildtype="$(echo "${11}" | tr '[A-Z]' '[a-z]')"
+buildtype="$(echo "${12}" | tr '[A-Z]' '[a-z]')"

[Peter Beverloo, 2012/08/23 10:45:48]

buildtype="$(echo "${@: -1}" | tr '[A-Z]' '[a-z]')"

would make this much less fragile.

[michaelbai, 2012/08/23 22:53:00]

Done.

 
 # TODO(yongsheng): enable build type by adding "${buildtype}" into the
 # end of parameter list once the workflow is ready to support release
 # mode.
-exec "${1}" "${2}" "${3}" "${4}" "${5}" "${6}" "${7}" "${8}" "${9}" "${10}"
+exec "${1}" "${2}" "${3}" "${4}" "${5}" "${6}" "${7}" "${8}" "${9}" "${10}" \
+     "${11}"

[Peter Beverloo, 2012/08/23 10:45:48]

exec "${@:1:$((${#@} - 1))}"

and when we want to add buildtype:
exec "${@:1:$((${#@} - 1))}" "${buildtype}"

The real problem is, however, that this stinks. We should be passing the build
type as the first parameter instead of the last one, as that would allow us to
use "shift" to remove it. The script would end up as something like:

buildtype="$(echo "${1}" | tr '[A-Z]' '[a-z]')"
shift
exec $@ "${buildtype}" 

[michaelbai, 2012/08/23 22:53:00]

Done.