Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: webkit/plugins/webplugininfo.h

Issue 10823434: [6] Moves CreateVersionFromString to plugin_utils and updates the callers. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: 2nd CL in series to delete PluginGroup. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/plugins/webplugininfo.h
diff --git a/webkit/plugins/webplugininfo.h b/webkit/plugins/webplugininfo.h
index cc09f7804915cddb667b439766bd8c90e6907fb7..89a92ec3b7f9a26b1d767d08c1840f57eea7e574 100644
--- a/webkit/plugins/webplugininfo.h
+++ b/webkit/plugins/webplugininfo.h
@@ -10,6 +10,7 @@
#include "base/basictypes.h"
#include "base/file_path.h"
+#include "base/version.h"
#include "webkit/plugins/webkit_plugins_export.h"
namespace webkit {
@@ -57,6 +58,11 @@ struct WEBKIT_PLUGINS_EXPORT WebPluginInfo {
const string16& fake_version,
const string16& fake_desc);
+ // Parse a version string as used by a plug-in. This method is more lenient
+ // in accepting weird version strings than Version::GetFromString().
+ static void CreateVersionFromString(const string16& version_string,
+ Version* version);
+
// The name of the plugin (i.e. Flash).
string16 name;

Powered by Google App Engine
This is Rietveld 408576698