chrome/browser/plugin_finder_unittest.cc - Issue 10823434: [6] Moves CreateVersionFromString to plugin_utils and updates the callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/plugin_finder_unittest.cc

Issue 10823434: [6] Moves CreateVersionFromString to plugin_utils and updates the callers. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: 2nd CL in series to delete PluginGroup. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/plugin_finder.cc ('K') | « chrome/browser/plugin_finder.cc ('k') | chrome/browser/plugin_installer.h » ('j') | chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/plugin_finder_unittest.cc

diff --git a/chrome/browser/plugin_finder_unittest.cc b/chrome/browser/plugin_finder_unittest.cc

index 8d3d46b8b1e09aeba75750d8db3c979102bf78fb..e6c2515df244a38c095da53022adaf3a17cdc5f7 100644

--- a/chrome/browser/plugin_finder_unittest.cc

+++ b/chrome/browser/plugin_finder_unittest.cc

@@ -55,5 +55,6 @@ TEST(PluginFinderTest, JsonSyntax) {

EXPECT_TRUE(PluginInstaller::ParseSecurityStatus(status_str, &status))

<< "Invalid security status \"" << status_str << "\"";

}

+ EXPECT_TRUE(plugin->GetString("group_name_matcher", &dummy_str));

}