Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: webkit/plugins/npapi/plugin_utils_unittest.cc

Issue 10823434: [6] Moves CreateVersionFromString to plugin_utils and updates the callers. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Added missing include <algorithm> Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/plugins/npapi/plugin_utils.cc ('k') | webkit/plugins/npapi/webplugin_delegate_impl_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/npapi/plugin_utils_unittest.cc
diff --git a/webkit/plugins/npapi/plugin_group_unittest.cc b/webkit/plugins/npapi/plugin_utils_unittest.cc
similarity index 86%
rename from webkit/plugins/npapi/plugin_group_unittest.cc
rename to webkit/plugins/npapi/plugin_utils_unittest.cc
index 90b520880566f93d0aada07683f986b2caac4eb1..d03606c3f94a767baf5393b5e7fafc065cae0208 100644
--- a/webkit/plugins/npapi/plugin_group_unittest.cc
+++ b/webkit/plugins/npapi/plugin_utils_unittest.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "webkit/plugins/npapi/plugin_group.h"
+#include "webkit/plugins/npapi/plugin_utils.h"
#include <string>
#include <vector>
@@ -15,7 +15,7 @@
namespace webkit {
namespace npapi {
-TEST(PluginGroupTest, VersionExtraction) {
+TEST(PluginUtilsTest, VersionExtraction) {
// Some real-world plugin versions (spaces, commata, parentheses, 'r', oh my)
const char* versions[][2] = {
{ "7.6.6 (1671)", "7.6.6.1671" }, // Quicktime
@@ -33,8 +33,7 @@ TEST(PluginGroupTest, VersionExtraction) {
for (size_t i = 0; i < arraysize(versions); i++) {
Version version;
- PluginGroup::CreateVersionFromString(ASCIIToUTF16(versions[i][0]),
- &version);
+ CreateVersionFromString(ASCIIToUTF16(versions[i][0]), &version);
ASSERT_TRUE(version.IsValid());
EXPECT_EQ(versions[i][1], version.GetString());
« no previous file with comments | « webkit/plugins/npapi/plugin_utils.cc ('k') | webkit/plugins/npapi/webplugin_delegate_impl_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698