content/browser/plugin_data_remover_impl.cc - Issue 10823434: [6] Moves CreateVersionFromString to plugin_utils and updates the callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/plugin_data_remover_impl.cc

Issue 10823434: [6] Moves CreateVersionFromString to plugin_utils and updates the callers. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/plugin_metadata/plugins_win.json ('K') | « chrome/browser/resources/plugin_metadata/plugins_win.json ('k') | content/utility/utility_thread_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/plugin_data_remover_impl.cc

diff --git a/content/browser/plugin_data_remover_impl.cc b/content/browser/plugin_data_remover_impl.cc

index 7981453ed28d5d3f61efa8f4023cd72a93c72d19..e5927934b111c13b3f19e1b7db2dcc4a07913a4e 100644

--- a/content/browser/plugin_data_remover_impl.cc

+++ b/content/browser/plugin_data_remover_impl.cc

@@ -19,7 +19,6 @@

#include "content/public/browser/browser_thread.h"

#include "content/public/common/pepper_plugin_info.h"

#include "ppapi/proxy/ppapi_messages.h"

-#include "webkit/plugins/npapi/plugin_group.h"

namespace content {

@@ -49,7 +48,7 @@ void PluginDataRemover::GetSupportedPlugins(

for (std::vector<webkit::WebPluginInfo>::iterator it = plugins.begin();

it != plugins.end(); ++it) {

Version version;

- webkit::npapi::PluginGroup::CreateVersionFromString(it->version, &version);

+ webkit::WebPluginInfo::CreateVersionFromString(it->version, &version);

if (version.IsValid() && min_version.CompareTo(version) == -1)

supported_plugins->push_back(*it);

}