[6] Moves CreateVersionFromString to plugin_utils and updates the callers.

chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/sys_string_conversions.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/content_settings/host_content_settings_map.h"
+#include "chrome/browser/plugin_installer.h"
 #include "chrome/browser/ui/content_settings/content_setting_bubble_model.h"
 #import "chrome/browser/ui/cocoa/hyperlink_button_cell.h"
 #import "chrome/browser/ui/cocoa/info_bubble_view.h"
 #import "chrome/browser/ui/cocoa/l10n_util.h"
 #include "content/public/browser/plugin_service.h"
 #include "grit/generated_resources.h"
 #include "skia/ext/skia_utils_mac.h"
 #import "third_party/GTM/AppKit/GTMUILocalizerAndLayoutTweaker.h"
 #include "ui/base/l10n/l10n_util.h"
+#include "webkit/plugins/npapi/plugin_list.h"
 
 using content::PluginService;
 
 namespace {
 
 // Height of one link in the popup list.
 const int kLinkHeight = 16;
 
 // Space between two popup links.
 const int kLinkPadding = 4;
@@ skipping 200 matching lines @@
   const std::set<std::string>& plugins =
       contentSettingBubbleModel_->bubble_content().resource_identifiers;
   if (plugins.empty()) {
     int delta = NSMinY([titleLabel_ frame]) -
                 NSMinY([blockedResourcesField_ frame]);
     [blockedResourcesField_ removeFromSuperview];
     NSRect frame = [[self window] frame];
     frame.size.height -= delta;
     [[self window] setFrame:frame display:NO];
   } else {
+    std::vector<webkit::WebPluginInfo> web_plugins;
+    PluginService::GetInstance()->GetPluginList()->

[Bernhard Bauer, 2012/08/21 19:14:52]

This method is deprecated in favor of using the asynchronous interface on
PluginService as well, but I think if you're going to use PluginFinder, you
should get by without this one.

+        GetPluginsNoRefresh(&web_plugins);
     for (std::set<std::string>::iterator it = plugins.begin();
          it != plugins.end(); ++it) {
       NSString* name = SysUTF16ToNSString(
-          PluginService::GetInstance()->GetPluginGroupName(*it));
+          PluginInstaller::GetGroupNameByIdentifier(web_plugins, *it));
       if ([name length] == 0)
         name = base::SysUTF8ToNSString(*it);
       [pluginArray addObject:name];
     }
     [blockedResourcesField_
         setStringValue:[pluginArray componentsJoinedByString:@"\n"]];
     [GTMUILocalizerAndLayoutTweaker
         sizeToFitFixedWidthTextField:blockedResourcesField_];
   }
 }
@@ skipping 229 matching lines @@
 - (IBAction)manageBlocking:(id)sender {
   contentSettingBubbleModel_->OnManageLinkClicked();
 }
 
 - (IBAction)closeBubble:(id)sender {
   contentSettingBubbleModel_->OnDoneClicked();
   [self close];
 }
 
 @end  // ContentSettingBubbleController