chrome/browser/plugin_finder_unittest.cc - Issue 10823434: [6] Moves CreateVersionFromString to plugin_utils and updates the callers.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/plugin_finder_unittest.cc

Issue 10823434: [6] Moves CreateVersionFromString to plugin_utils and updates the callers. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: 2nd CL in series to delete PluginGroup. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/plugin_finder.cc ('K') | « chrome/browser/plugin_finder.cc ('k') | chrome/browser/plugin_installer.h » ('j') | chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/plugin_finder.h"	5 #include "chrome/browser/plugin_finder.h"

6	6

7 #include "base/values.h"	7 #include "base/values.h"

8 #include "chrome/browser/plugin_installer.h"	8 #include "chrome/browser/plugin_installer.h"

9 #include "testing/gtest/include/gtest/gtest.h"	9 #include "testing/gtest/include/gtest/gtest.h"

10 #include "webkit/plugins/npapi/plugin_list.h"	10 #include "webkit/plugins/npapi/plugin_list.h"

(...skipping 37 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
48 DictionaryValue* version_dict = NULL;	48 DictionaryValue* version_dict = NULL;

49 ASSERT_TRUE((*it)->GetAsDictionary(&version_dict));	49 ASSERT_TRUE((*it)->GetAsDictionary(&version_dict));

50 EXPECT_TRUE(version_dict->GetString("version", &dummy_str));	50 EXPECT_TRUE(version_dict->GetString("version", &dummy_str));

51 std::string status_str;	51 std::string status_str;

52 EXPECT_TRUE(version_dict->GetString("status", &status_str));	52 EXPECT_TRUE(version_dict->GetString("status", &status_str));

53 PluginInstaller::SecurityStatus status =	53 PluginInstaller::SecurityStatus status =

54 PluginInstaller::SECURITY_STATUS_UP_TO_DATE;	54 PluginInstaller::SECURITY_STATUS_UP_TO_DATE;

55 EXPECT_TRUE(PluginInstaller::ParseSecurityStatus(status_str, &status))	55 EXPECT_TRUE(PluginInstaller::ParseSecurityStatus(status_str, &status))

56 << "Invalid security status \"" << status_str << "\"";	56 << "Invalid security status \"" << status_str << "\"";

57 }	57 }

	58 EXPECT_TRUE(plugin->GetString("group_name_matcher", &dummy_str));

58 }	59 }

59 }	60 }

OLD	NEW