Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Side by Side Diff: content/utility/utility_thread_impl.cc

Issue 10823434: [6] Moves CreateVersionFromString to plugin_utils and updates the callers. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/utility/utility_thread_impl.h" 5 #include "content/utility/utility_thread_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/file_path.h" 10 #include "base/file_path.h"
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 // http://mail.gnome.org/archives/gnome-announce-list/2011-October/msg00041.ht ml 137 // http://mail.gnome.org/archives/gnome-announce-list/2011-October/msg00041.ht ml
138 #if defined(TOOLKIT_GTK) 138 #if defined(TOOLKIT_GTK)
139 #if !(GLIB_CHECK_VERSION(2, 31, 0)) 139 #if !(GLIB_CHECK_VERSION(2, 31, 0))
140 if (!g_thread_get_initialized()) { 140 if (!g_thread_get_initialized()) {
141 g_thread_init(NULL); 141 g_thread_init(NULL);
142 } 142 }
143 #endif 143 #endif
144 gfx::GtkInitFromCommandLine(*CommandLine::ForCurrentProcess()); 144 gfx::GtkInitFromCommandLine(*CommandLine::ForCurrentProcess());
145 #endif 145 #endif
146 146
147 ScopedVector<webkit::npapi::PluginGroup> plugin_groups; 147 std::vector<webkit::WebPluginInfo> plugins;
148 // TODO(bauerb): If we restart loading plug-ins, we might mess up the logic in 148 // TODO(bauerb): If we restart loading plug-ins, we might mess up the logic in
149 // PluginList::ShouldLoadPlugin due to missing the previously loaded plug-ins 149 // PluginList::ShouldLoadPlugin due to missing the previously loaded plug-ins
150 // in |plugin_groups|. 150 // in |plugin_groups|.
151 for (size_t i = 0; i < plugin_paths.size(); ++i) { 151 for (size_t i = 0; i < plugin_paths.size(); ++i) {
152 webkit::WebPluginInfo plugin; 152 webkit::WebPluginInfo plugin;
153 if (!plugin_list->LoadPlugin(plugin_paths[i], &plugin_groups, &plugin)) 153 if (!plugin_list->LoadPluginIntoPluginList(
154 plugin_paths[i], &plugins, &plugin))
154 Send(new UtilityHostMsg_LoadPluginFailed(i, plugin_paths[i])); 155 Send(new UtilityHostMsg_LoadPluginFailed(i, plugin_paths[i]));
155 else 156 else
156 Send(new UtilityHostMsg_LoadedPlugin(i, plugin)); 157 Send(new UtilityHostMsg_LoadedPlugin(i, plugin));
157 } 158 }
158 159
159 ReleaseProcessIfNeeded(); 160 ReleaseProcessIfNeeded();
160 } 161 }
161 #endif 162 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698