gdata: Change callback type of GDataDirectoryService::GetEntryInfoByResourceId()

gdata: Change callback type of GDataDirectoryService::GetEntryInfoByResourceId()

This function should take  GetEntryInfoWithFilePathCallback instead of
GetEntryInfoCallback so that the callers can get the drive file path.
The new signature matches GDataFileSystem::GetEntryInfoByResourceId()

Along the way, add CopyResultsFromGetEntryInfoWithFilePathCallback() to
gdata_test_util.h.

BUG=143517
TEST=out/Release/unit_tests --gtest_filter='GDataDirectoryServiceTest.*'

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152442

[satorux1, 2012-08-20 22:56:28]

I should have done this way in the original patch, but I was sloppy. :~(

[achuithb, 2012-08-20 23:19:09]

lgtm

http://codereview.chromium.org/10823427/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_test_util.h (right):

http://codereview.chromium.org/10823427/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_test_util.h:81: void
CopyResultsFromGetEntryInfoWithFilePathCallback(
Do we really need this here? Why not put this in the anonymous scope of
gdata_directory_service_unittest.cc

It's harder to look up because of the lack of locality. 

There was also a discussion on chromium-dev to avoid util files because they
become a dumping ground.

The function bodies are so small and trivial that it's probably worthwhile to
just copy them in all the unit tests that they are used in. and get rid of this
file altogether.

But that's just my opinion. It's up to you to leave as is.

[satorux1, 2012-08-20 23:24:43]

http://codereview.chromium.org/10823427/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_test_util.h (right):

http://codereview.chromium.org/10823427/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_test_util.h:81: void
CopyResultsFromGetEntryInfoWithFilePathCallback(
On 2012/08/20 23:19:09, achuith.bhandarkar wrote:
> Do we really need this here? Why not put this in the anonymous scope of
> gdata_directory_service_unittest.cc

I plan to use these Copy* functions from gdata_file_system_unittest.cc. As of
now, CallbackHelper class is used to copy results, but using these functions
would be cleaner. crbug.com/141521


> 
> It's harder to look up because of the lack of locality. 
> 
> There was also a discussion on chromium-dev to avoid util files because they
> become a dumping ground.
> 
> The function bodies are so small and trivial that it's probably worthwhile to
> just copy them in all the unit tests that they are used in. and get rid of
this
> file altogether.
> 
> But that's just my opinion. It's up to you to leave as is.

[commit-bot: I haz the power, 2012-08-20 23:40:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/satorux@chromium.org/10823427/1