Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 10823426: Temporarily allow warnings in libvpx (Closed)

Created:
7 years ago by scottmg
Modified:
7 years ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Temporarily allow warnings in libvpx Another attempt at this. Still haven't managed to get a libvpx that's warning-free on Windows. So, adding a variable to build/common.gypi that defaults third_party code to have warnings as errors, but allows specific packages to temporarily disable. Addition of variable here: http://chromiumcodereview.appspot.com/10827429/ Previous failed attempt was here: http://chromiumcodereview.appspot.com/10850007/

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M libvpx.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scottmg
7 years ago (2012-08-20 23:40:08 UTC) #1
Nico
lgtm
7 years ago (2012-08-20 23:41:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10823426/2001
7 years ago (2012-08-20 23:42:34 UTC) #3
commit-bot: I haz the power
7 years ago (2012-08-20 23:42:47 UTC) #4
Change committed as 152423

Powered by Google App Engine
This is Rietveld 408576698