Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Side by Side Diff: runtime/vm/stack_frame_test.cc

Issue 10823416: Removed incorrect EXPECT that gets triggered with low optimization_counter_threshold. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "include/dart_api.h" 5 #include "include/dart_api.h"
6 #include "platform/assert.h" 6 #include "platform/assert.h"
7 #include "vm/class_finalizer.h" 7 #include "vm/class_finalizer.h"
8 #include "vm/compiler.h" 8 #include "vm/compiler.h"
9 #include "vm/dart_api_impl.h" 9 #include "vm/dart_api_impl.h"
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 StackFrame* frame = frames.NextFrame(); 89 StackFrame* frame = frames.NextFrame();
90 while (frame != NULL) { 90 while (frame != NULL) {
91 if (count == frame_index) { 91 if (count == frame_index) {
92 // Find the function corresponding to this frame and check if it 92 // Find the function corresponding to this frame and check if it
93 // matches the function name passed in. 93 // matches the function name passed in.
94 const Function& function = 94 const Function& function =
95 Function::Handle(frame->LookupDartFunction()); 95 Function::Handle(frame->LookupDartFunction());
96 if (function.IsNull()) { 96 if (function.IsNull()) {
97 FATAL("StackFrame_validateFrame fails, invalid dart frame.\n"); 97 FATAL("StackFrame_validateFrame fails, invalid dart frame.\n");
98 } 98 }
99 const Code& code = Code::Handle(frame->LookupDartCode());
100 EXPECT(code.raw() == function.unoptimized_code());
101 const char* name = function.ToFullyQualifiedCString(); 99 const char* name = function.ToFullyQualifiedCString();
102 // Currently all unit tests are loaded as being part of dart:core-lib. 100 // Currently all unit tests are loaded as being part of dart:core-lib.
103 Isolate* isolate = Isolate::Current(); 101 Isolate* isolate = Isolate::Current();
104 String& url = String::Handle(String::New(TestCase::url())); 102 String& url = String::Handle(String::New(TestCase::url()));
105 const Library& lib = Library::Handle(Library::LookupLibrary(url)); 103 const Library& lib = Library::Handle(Library::LookupLibrary(url));
106 ASSERT(!lib.IsNull()); 104 ASSERT(!lib.IsNull());
107 const char* lib_name = String::Handle(lib.url()).ToCString(); 105 const char* lib_name = String::Handle(lib.url()).ToCString();
108 intptr_t length = OS::SNPrint(NULL, 0, "%s_%s", lib_name, expected_name); 106 intptr_t length = OS::SNPrint(NULL, 0, "%s_%s", lib_name, expected_name);
109 char* full_name = isolate->current_zone()->Alloc<char>(length + 1); 107 char* full_name = isolate->current_zone()->Alloc<char>(length + 1);
110 ASSERT(full_name != NULL); 108 ASSERT(full_name != NULL);
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 "}"; 282 "}";
285 Dart_Handle lib = TestCase::LoadTestScript( 283 Dart_Handle lib = TestCase::LoadTestScript(
286 kScriptChars, 284 kScriptChars,
287 reinterpret_cast<Dart_NativeEntryResolver>(native_lookup)); 285 reinterpret_cast<Dart_NativeEntryResolver>(native_lookup));
288 Dart_Handle cls = Dart_GetClass(lib, Dart_NewString("StackFrame2Test")); 286 Dart_Handle cls = Dart_GetClass(lib, Dart_NewString("StackFrame2Test"));
289 EXPECT_VALID(Dart_Invoke(cls, Dart_NewString("testMain"), 0, NULL)); 287 EXPECT_VALID(Dart_Invoke(cls, Dart_NewString("testMain"), 0, NULL));
290 } 288 }
291 #endif // TARGET_ARCH_IA32 || TARGET_ARCH_X64. 289 #endif // TARGET_ARCH_IA32 || TARGET_ARCH_X64.
292 290
293 } // namespace dart 291 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698