Issue 10823414: Also hide incognito switcher when no regular window is available.

Issue 10823414: Also hide incognito switcher when no regular window is available. (Closed)

Created:
8 years, 4 months ago by MAD

Modified:
8 years, 3 months ago

Reviewers:
Peter Kasting, robertshield

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Also hide incognito switcher when no regular window is available. BUG=142710 TEST=Make sure the incognito switcher is only shown when there are both incognito and normal windows available. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153433

Patch Set 1 #

Patch Set 2 : Adapted to upstream API name change. #

Patch Set 3 : Sync'd to Tip Of Tree. #

Patch Set 4 : Sync'd to ToT... #

Patch Set 5 : Sync'd to Tip Of Tree #

Patch Set 6 : Now with the API available, so that we can run try bots... #

Total comments: 2

Patch Set 7 : OWNER review comments addressed. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	chrome/browser/ui/views/frame/browser_view_layout.cc	View	1 2 3 4 5 6	2 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

MAD

This depends on another pending change (https://chromiumcodereview.appspot.com/10855183/), and will need OWNERS review, but please take ...

8 years, 4 months ago (2012-08-20 16:48:35 UTC) #1

MAD

OWNERS review please... Note that this is using a currently deprecated API (FindBrowserWithProfile) that will ...

8 years, 4 months ago (2012-08-24 13:24:39 UTC) #3

Peter Kasting

LGTM https://chromiumcodereview.appspot.com/10823414/diff/16001/chrome/browser/ui/views/frame/browser_view_layout.cc File chrome/browser/ui/views/frame/browser_view_layout.cc (right): https://chromiumcodereview.appspot.com/10823414/diff/16001/chrome/browser/ui/views/frame/browser_view_layout.cc#newcode325 chrome/browser/ui/views/frame/browser_view_layout.cc:325: // case that works right now. Nit: Is ...

8 years, 4 months ago (2012-08-24 22:19:32 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mad@chromium.org/10823414/7004

8 years, 3 months ago (2012-08-26 22:48:27 UTC) #5

Change committed as 153433

Expand Messages | Collapse Messages