Issue 10823410: [Android] Add Chrome Shell package name constant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10823410: [Android] Add Chrome Shell package name constant. (Closed)

Created:
8 years, 4 months ago by mkosiba (inactive)

Modified:
8 years, 4 months ago

Reviewers:
hans, Philippe

CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[Android] Add Chrome Shell package name constant. This adds the constant for the Chrome Shell package which we're bringing up downstream at the moment. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152371

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	build/android/pylib/constants.py	View		2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 6 (0 generated)

Philippe

On 2012/08/20 14:25:56, Martin Kosiba wrote: LGTM. You might need someone else's approval to be ...

8 years, 4 months ago (2012-08-20 14:32:30 UTC) #2

hans

On 2012/08/20 14:51:23, Martin Kosiba wrote: > Hans, > please take a look. rubberstamp lgtm

8 years, 4 months ago (2012-08-20 14:52:08 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/10823410/1

8 years, 4 months ago (2012-08-20 15:00:22 UTC) #5

Change committed as 152371