Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1212)

Unified Diff: chrome/browser/ui/views/content_setting_bubble_contents.h

Issue 10823391: views: ContentSettingBubbleContents does not need to store a pointer to Profile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/content_setting_bubble_contents.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/content_setting_bubble_contents.h
diff --git a/chrome/browser/ui/views/content_setting_bubble_contents.h b/chrome/browser/ui/views/content_setting_bubble_contents.h
index c4b0cf1b6f9a6297e26cfe5e63957512392bebce..7f156001a95e523601f29c6b7ae229df543a283f 100644
--- a/chrome/browser/ui/views/content_setting_bubble_contents.h
+++ b/chrome/browser/ui/views/content_setting_bubble_contents.h
@@ -16,18 +16,7 @@
#include "ui/views/controls/button/button.h"
#include "ui/views/controls/link_listener.h"
-// ContentSettingBubbleContents is used when the user turns on different kinds
-// of content blocking (e.g. "block images"). When viewing a page with blocked
-// content, icons appear in the omnibox corresponding to the content types that
-// were blocked, and the user can click one to get a bubble hosting a few
-// controls. This class provides the content of that bubble. In general,
-// these bubbles typically have a title, a pair of radio buttons for toggling
-// the blocking settings for the current site, a close button, and a link to
-// get to a more comprehensive settings management dialog. A few types have
-// more or fewer controls than this.
-
class ContentSettingBubbleModel;
-class Profile;
namespace content {
class WebContents;
@@ -38,6 +27,15 @@ class TextButton;
class RadioButton;
}
+// ContentSettingBubbleContents is used when the user turns on different kinds
+// of content blocking (e.g. "block images"). When viewing a page with blocked
+// content, icons appear in the omnibox corresponding to the content types that
+// were blocked, and the user can click one to get a bubble hosting a few
+// controls. This class provides the content of that bubble. In general,
+// these bubbles typically have a title, a pair of radio buttons for toggling
+// the blocking settings for the current site, a close button, and a link to
+// get to a more comprehensive settings management dialog. A few types have
+// more or fewer controls than this.
class ContentSettingBubbleContents : public views::BubbleDelegateView,
public views::ButtonListener,
public views::LinkListener,
@@ -45,7 +43,6 @@ class ContentSettingBubbleContents : public views::BubbleDelegateView,
public:
ContentSettingBubbleContents(
ContentSettingBubbleModel* content_setting_bubble_model,
- Profile* profile,
content::WebContents* web_contents,
views::View* anchor_view,
views::BubbleBorder::ArrowLocation arrow_location);
@@ -80,9 +77,6 @@ class ContentSettingBubbleContents : public views::BubbleDelegateView,
// Provides data for this bubble.
scoped_ptr<ContentSettingBubbleModel> content_setting_bubble_model_;
- // The active profile.
- Profile* profile_;
-
// The active web contents.
content::WebContents* web_contents_;
« no previous file with comments | « no previous file | chrome/browser/ui/views/content_setting_bubble_contents.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698