Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 10823391: views: ContentSettingBubbleContents does not need to store a pointer to Profile. (Closed)

Created:
8 years, 4 months ago by tfarina
Modified:
8 years, 4 months ago
Reviewers:
Peter Kasting, sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

views: ContentSettingBubbleContents does not need to store a pointer to Profile. It's unused, so we can remove. R=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152760

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -19 lines) Patch
M chrome/browser/ui/views/content_setting_bubble_contents.h View 4 chunks +9 lines, -15 lines 0 comments Download
M chrome/browser/ui/views/content_setting_bubble_contents.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/content_setting_image_view.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
8 years, 4 months ago (2012-08-17 14:12:17 UTC) #1
tfarina
ping??
8 years, 4 months ago (2012-08-21 01:43:56 UTC) #2
tfarina
Hi Scott, could you review this to me? Thanks.
8 years, 4 months ago (2012-08-21 15:30:39 UTC) #3
sky
8 years, 4 months ago (2012-08-21 16:03:30 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698