Full typedef support in dartdoc.

tests/compiler/dart2js/mirrors_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #import("../../../pkg/dartdoc/mirrors/mirrors.dart");
 #import("../../../pkg/dartdoc/mirrors/mirrors_util.dart");
 
 #import('dart:io');
 
 int count(Iterable iterable) {
@@ skipping 11 matching lines @@
     }
   }
   return false;
 }
 
 main() {
   var scriptPath = new Path.fromNative(new Options().script);
   var dirPath = scriptPath.directoryPath;
   var libPath = dirPath.join(new Path.fromNative('../../../'));
   var inputPath = dirPath.join(new Path.fromNative('mirrors_helper.dart'));
-  var compilation = new Compilation(inputPath, libPath);
+  var compilation = new Compilation.library([inputPath], libPath);

[Johnni Winther, 2012/08/17 13:54:27]

This will make the path used by dartdoc tested within unittests. Hopefully we'll
then catch dartdoc breaks earlier.

[ahe, 2012/08/21 08:50:28]

I was surprised that you didn't land this change by itself.

   Expect.isNotNull(compilation, "No compilation created");
 
   var mirrors = compilation.mirrors;
   Expect.isNotNull(mirrors, "No mirror system returned from compilation");
 
   var libraries = mirrors.libraries;
   Expect.isNotNull(libraries, "No libraries map returned");
   Expect.isFalse(libraries.isEmpty(), "Empty libraries map returned");
 
   var helperLibrary = findMirror(libraries, "mirrors_helper");
@@ skipping 503 matching lines @@
   Expect.isFalse(funcTypedef.isClass, "Typedef is class");
   Expect.isFalse(funcTypedef.isInterface, "Typedef is interface");
   Expect.isFalse(funcTypedef.isPrivate, "Typedef is private");
   Expect.isNull(funcTypedef.defaultType,
                 "Typedef default type is non-null");
   // TODO(johnniwinther): Should not throw an exception since the type should
   // not be the declaration.
   Expect.throws(() => funcTypedef.typeArguments,
                 (exception) => true,
                 "Typedef has type arguments");
-  Expect.isNotNull(funcTypedef.typeVariables, "Type variables is null");
-  // TODO(johnniwinther): Should return a non-empty map.
-  Expect.isTrue(funcTypedef.typeVariables.isEmpty(),
-                "Type variables is non-empty");
-  // TODO(johnniwinther): Provide access to the definition type.
-  Expect.isNull(funcTypedef.definition, "Typedef definition is not null");
+  var funcTypedefTypeVariables = funcTypedef.typeVariables;
+  Expect.isNotNull(funcTypedefTypeVariables, "Type variables is null");

[ahe, 2012/08/21 08:50:28]

The String argument to isNotNull is virtually pointless in this case.

[Johnni Winther, 2012/08/21 09:30:27]

Done.

+  Expect.equals(2, funcTypedefTypeVariables.length,
+                "Unexpected type variable count");

[ahe, 2012/08/21 08:50:28]

Ditto.

[Johnni Winther, 2012/08/21 09:30:27]

Done.

+
+  var funcTypedefDefinition = funcTypedef.definition;
+  Expect.isNotNull(funcTypedefDefinition, "Typedef definition is null");

[ahe, 2012/08/21 08:50:28]

Ditto.

[Johnni Winther, 2012/08/21 09:30:27]

Done.

+  Expect.isTrue(funcTypedefDefinition is FunctionTypeMirror,
+                "Unexpected typedef definition");

[ahe, 2012/08/21 08:50:28]

Ditto.

[Johnni Winther, 2012/08/21 09:30:27]

Done.

 
   Expect.stringEquals("func2", method3Parameter2.simpleName,
                       "Unexpected parameter simpleName");
   Expect.stringEquals("mirrors_helper.Baz.method3#func2",
                       method3Parameter2.qualifiedName,
                       "Unexpected parameter qualifiedName");
   Expect.isFalse(method3Parameter2.hasDefaultValue,
                  "Parameter 'func2' has default value: "
                  "${method3Parameter2.defaultValue}");
   Expect.isNull(method3Parameter2.defaultValue,
@@ skipping 60 matching lines @@
   Expect.stringEquals('negate', operator_negate.operatorName,
                       "Unexpected operatorName");
 
 
   var bazClassConstructors = bazClass.constructors;
   Expect.isNotNull(bazClassConstructors, "Constructors map is null");
   Expect.equals(3, bazClassConstructors.length,
                 "Unexpected number of constructors");
   // TODO(johnniwinther): Add tests of constructors.
 }