Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 10823387: Revert 152059 - Gradient overlay for constrained window (Closed)

Created:
8 years, 4 months ago by sail
Modified:
8 years, 4 months ago
Reviewers:
sail
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 152059 - Gradient overlay for constrained window As a part of the new constrained window look and feel we're changing the the solid gray overlay to a gradient overlay. The overlay fades in on show and fades out on hide. Screenshots: light background: http://i.imgur.com/GJj6L.png dark background: http://i.imgur.com/s37da.png BUG=140520 TEST=Run with --enable-frameless-constrained-dialogs. Navigate to http://www.imagemator.com/ Click "Click to pick an image." Review URL: https://chromiumcodereview.appspot.com/10855151 TBR=sail@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152062

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -281 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
MM chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/chrome_render_view_observer.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.cc View 2 chunks +10 lines, -23 lines 0 comments Download
D chrome/renderer/webview_animating_overlay.h View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/renderer/webview_animating_overlay.cc View 1 chunk +0 lines, -112 lines 0 comments Download
D chrome/renderer/webview_animating_overlay_browsertest.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M content/public/renderer/render_view.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/test/render_view_test.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/public/test/render_view_test.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/base/animation/animation_unittest.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M ui/base/animation/linear_animation.h View 2 chunks +1 line, -7 lines 0 comments Download
M ui/base/animation/linear_animation.cc View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
sail
8 years, 4 months ago (2012-08-17 07:49:33 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698