[Coverity] Pass-by-ref instead of pass-by-val

[Coverity] Pass-by-ref instead of pass-by-val

CID=104687,104688
CID_COUNT=2

R=sky@chromium.org
BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152430

[sky, 2012-08-20 14:25:19]

LGTM

[commit-bot: I haz the power, 2012-08-20 20:38:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/10823385/1

[commit-bot: I haz the power, 2012-08-20 23:48:56]

Change committed as 152430

[Nico, 2012-09-19 10:29:16]

https://chromiumcodereview.appspot.com/10823385/diff/1/chrome/browser/favicon...
File chrome/browser/favicon/select_favicon_frames.cc (right):

https://chromiumcodereview.appspot.com/10823385/diff/1/chrome/browser/favicon...
chrome/browser/favicon/select_favicon_frames.cc:27: SkBitmap PadWithBorder(const
SkBitmap& contents,
SkBitmaps are refcounted and by design very cheap to copy. We rely on this
property in many places. I intentionally didn't pass them by ref. (Not that
doing it hurts much either, but it's more code and unnecessary.)

[sky, 2012-09-19 14:25:05]

https://chromiumcodereview.appspot.com/10823385/diff/1/chrome/browser/favicon...
File chrome/browser/favicon/select_favicon_frames.cc (right):

https://chromiumcodereview.appspot.com/10823385/diff/1/chrome/browser/favicon...
chrome/browser/favicon/select_favicon_frames.cc:27: SkBitmap PadWithBorder(const
SkBitmap& contents,
On 2012/09/19 10:29:16, Nico wrote:
> SkBitmaps are refcounted and by design very cheap to copy. We rely on this
> property in many places. I intentionally didn't pass them by ref. (Not that
> doing it hurts much either, but it's more code and unnecessary.)

We should still pass by ref if possible.