Disable adb root default call in android_commands

Disable adb root default call in android_commands

We need to change downstream scripts to explicitly call this.
This is causing devices to drop offline during the adb root command.

I will manually pull this change downstream.

BUG=143109
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152019

[Yaron, 2012-08-16 23:49:24]

lgtm

https://chromiumcodereview.appspot.com/10823382/diff/1/build/android/pylib/an...
File build/android/pylib/android_commands.py (right):

https://chromiumcodereview.appspot.com/10823382/diff/1/build/android/pylib/an...
build/android/pylib/android_commands.py:227: # So many users require root that
we just always do it. This could
Please update this comment.

[Satish, 2012-08-17 09:32:58]

https://chromiumcodereview.appspot.com/10823382/diff/4002/build/android/pylib...
File build/android/pylib/android_commands.py (right):

https://chromiumcodereview.appspot.com/10823382/diff/4002/build/android/pylib...
build/android/pylib/android_commands.py:239: self._root_enabled =
self.Adb().EnableAdbRoot()
I see in __init__ we check if adb is already in root mode and set this flag. So
can we check if that is true already and if so return early instead of trying to
enable root and wait again?

[Isaac (away), 2012-08-17 09:34:37]

https://chromiumcodereview.appspot.com/10823382/diff/4002/build/android/pylib...
File build/android/pylib/android_commands.py (right):

https://chromiumcodereview.appspot.com/10823382/diff/4002/build/android/pylib...
build/android/pylib/android_commands.py:239: self._root_enabled =
self.Adb().EnableAdbRoot()
On 2012/08/17 09:32:58, Satish wrote:
> I see in __init__ we check if adb is already in root mode and set this flag.
So
> can we check if that is true already and if so return early instead of trying
to
> enable root and wait again?

sure.  This function isn't called right now and might be culled entirely.  But
if I do hook into it I will add that.

[Isaac (away), 2012-08-17 19:09:18]

Actually I am going to remove EnableAdbRoot and we can re-add it if we later
need to.