Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 10823381: Fix a crash in TestingAutomationProvider::GetTabInfo on ChromeOS. (Closed)

Created:
8 years, 4 months ago by craigdh
Modified:
8 years, 4 months ago
Reviewers:
dennis_jeffrey, jam
CC:
chromium-reviews, robertshield, kkania
Visibility:
Public.

Description

Fix a crash in TestingAutomationProvider::GetTabInfo on ChromeOS. BUG=143293 TEST=functional/navigation.py Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152048

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
craigdh
8 years, 4 months ago (2012-08-16 23:37:50 UTC) #1
dennis_jeffrey
LGTM
8 years, 4 months ago (2012-08-16 23:41:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/10823381/1
8 years, 4 months ago (2012-08-16 23:47:11 UTC) #3
commit-bot: I haz the power
Presubmit check for 10823381-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-16 23:47:13 UTC) #4
craigdh
Fix for http://crbug.com/143293 +John: OWNERS approval
8 years, 4 months ago (2012-08-16 23:49:17 UTC) #5
jam
lgtm
8 years, 4 months ago (2012-08-17 00:14:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/10823381/1
8 years, 4 months ago (2012-08-17 00:16:33 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-17 04:43:10 UTC) #8
Change committed as 152048

Powered by Google App Engine
This is Rietveld 408576698