Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 10823380: Wires up MouseEvent changed flags on windows. (Closed)

Created:
8 years, 4 months ago by sky
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Wires up MouseEvent changed flags on windows. BUG=140102 TEST=none R=ben@chromium.org,msw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152331

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M ui/base/win/events_win.cc View 1 2 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sky
8 years, 4 months ago (2012-08-16 23:28:48 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 4 months ago (2012-08-16 23:33:08 UTC) #2
msw
LGTM too; thanks!
8 years, 4 months ago (2012-08-16 23:37:46 UTC) #3
msw
Sorry, I actually do have one nit. http://codereview.chromium.org/10823380/diff/1/ui/base/win/events_win.cc File ui/base/win/events_win.cc (right): http://codereview.chromium.org/10823380/diff/1/ui/base/win/events_win.cc#newcode232 ui/base/win/events_win.cc:232: default: Oops, ...
8 years, 4 months ago (2012-08-16 23:42:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/10823380/7001
8 years, 4 months ago (2012-08-20 13:54:31 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-20 16:08:50 UTC) #6
Change committed as 152331

Powered by Google App Engine
This is Rietveld 408576698