Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: content/gpu/gpu_child_thread.cc

Issue 10823375: GPU process exits with error code on failure to initialize. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/gpu/gpu_child_thread.cc
===================================================================
--- content/gpu/gpu_child_thread.cc (revision 151970)
+++ content/gpu/gpu_child_thread.cc (working copy)
@@ -17,6 +17,7 @@
#include "content/gpu/gpu_watchdog_thread.h"
#include "content/public/common/content_client.h"
#include "content/public/common/content_switches.h"
+#include "content/public/common/result_codes.h"
#include "ipc/ipc_channel_handle.h"
#include "ipc/ipc_sync_message_filter.h"
#include "ui/gl/gl_implementation.h"
@@ -114,8 +115,12 @@
void GpuChildThread::OnInitialize() {
if (dead_on_arrival_) {
VLOG(1) << "Exiting GPU process due to errors during initialization";
- MessageLoop::current()->Quit();
- return;
+
+ // Exit with the exit code that would be returned if the GPU process was
+ // killed using task mamager so that it does not count as a crash.
+ // TODO(apatrick): this is temporary to see if this impacts the crash
+ // statistics. If it does then the crash accounting should be fixed.
+ exit(content::RESULT_CODE_KILLED);
}
// We don't need to pipe log messages if we are running the GPU thread in
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698