rename ExtensionProvider and PlatformAppProvider class

rename ExtensionProvider and PlatformAppProvider class

Rename ExtensionProver => CustomExtensionProvider,
PlatformAppProvider => InternalExtensionProvider.


BUG=140610
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152606

[Mihai Parparita -not on Chrome, 2012-08-16 18:31:38]

https://chromiumcodereview.appspot.com/10823370/diff/1/chrome/browser/content...
File
chrome/browser/content_settings/content_settings_custom_extension_provider.h
(right):

https://chromiumcodereview.appspot.com/10823370/diff/1/chrome/browser/content...
chrome/browser/content_settings/content_settings_custom_extension_provider.h:5:
#ifndef
CHROME_BROWSER_CONTENT_SETTINGS_CONTENT_SETTINGS_CUSTOM_EXTENSION_PROVIDER_H_
Gaurav asked me why most of the file names in this directory have a
content_settings_ prefix (despite already being in the content_settings
directory), and I couldn't think of a reason. I told him to be consistent
anyway, but you may want to consider dropping it, so that it's less repetitive.

[Bernhard Bauer, 2012-08-16 18:45:10]

LGTM, thanks!

[Bernhard Bauer, 2012-08-16 18:49:57]

https://chromiumcodereview.appspot.com/10823370/diff/1/chrome/browser/content...
File
chrome/browser/content_settings/content_settings_custom_extension_provider.h
(right):

https://chromiumcodereview.appspot.com/10823370/diff/1/chrome/browser/content...
chrome/browser/content_settings/content_settings_custom_extension_provider.h:5:
#ifndef
CHROME_BROWSER_CONTENT_SETTINGS_CONTENT_SETTINGS_CUSTOM_EXTENSION_PROVIDER_H_
On 2012/08/16 18:31:38, Mihai Parparita wrote:
> Gaurav asked me why most of the file names in this directory have a
> content_settings_ prefix (despite already being in the content_settings
> directory), and I couldn't think of a reason. I told him to be consistent
> anyway, but you may want to consider dropping it, so that it's less
repetitive.

I think there are other cases where we repeat the subdirectory name in the file
name, like for ipc/. Admittedly that's a far shorter prefix though ;-)

[commit-bot: I haz the power, 2012-08-16 19:36:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grv@chromium.org/10823370/1

[commit-bot: I haz the power, 2012-08-16 19:36:12]

Presubmit check for 10823370-1 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome
    chrome/browser/extensions

Presubmit checks took 1.6s to calculate.

[Gaurav, 2012-08-16 19:39:40]

Hi Mihai,

Need LGTM for
chrome/browser/extensions/api/content_settings/content_settings_store.h

Thanks,
--Gaurav

[Mihai Parparita -not on Chrome, 2012-08-16 19:40:03]

LGMT

[Mihai Parparita -not on Chrome, 2012-08-16 19:40:26]

LGTM too :)

[Gaurav, 2012-08-16 19:41:19]

On 2012/08/16 19:40:26, Mihai Parparita wrote:
> LGTM too :)

That was like in a flash of a second. Thanks :)

[commit-bot: I haz the power, 2012-08-16 19:41:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grv@chromium.org/10823370/1

[commit-bot: I haz the power, 2012-08-16 19:41:33]

Presubmit check for 10823370-1 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

Presubmit checks took 1.9s to calculate.

[Gaurav, 2012-08-16 19:45:38]

Hi James,

Need an LGTM from you for the chrome_browser.gypi file.

Thanks,
-- Gaurav

[James Hawkins, 2012-08-19 06:20:12]

lgtm

[commit-bot: I haz the power, 2012-08-20 17:34:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grv@chromium.org/10823370/1

[commit-bot: I haz the power, 2012-08-20 21:00:31]

Try job failure for 10823370-1 (retry) on linux_chromeos for step
"browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-08-21 16:45:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grv@chromium.org/10823370/1

[commit-bot: I haz the power, 2012-08-21 19:19:44]

Change committed as 152606