Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 10823351: Update launcher status images (Closed)

Created:
8 years, 4 months ago by DaveMoore
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, oshima+watch_chromium.org, ben+watch_chromium.org
Visibility:
Public.

Description

Update launcher status images BUG=141572 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151924

Patch Set 1 #

Patch Set 2 : Missed 1X incognito browser panel changes #

Patch Set 3 : permissions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ash/launcher/launcher_button.cc View 1 2 2 chunks +17 lines, -15 lines 0 comments Download
M ui/resources/default_100_percent/ash/launcher_browser.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/ash/launcher_browser_panel.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/ash/launcher_incognito_browser.png View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/ash/launcher_incognito_browser_panel.png View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/ash/launcher_underline_active.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/ash/launcher_underline_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/ash/launcher_underline_running.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/ash/launcher_browser.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/ash/launcher_browser_panel.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/ash/launcher_incognito_browser.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/ash/launcher_incognito_browser_panel.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/ash/launcher_underline_active.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/ash/launcher_underline_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/ash/launcher_underline_running.png View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
DaveMoore
8 years, 4 months ago (2012-08-15 22:14:45 UTC) #1
sky
LGTM
8 years, 4 months ago (2012-08-16 00:16:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davemoore@chromium.org/10823351/9001
8 years, 4 months ago (2012-08-16 16:14:21 UTC) #3
commit-bot: I haz the power
Presubmit check for 10823351-9001 failed and returned exit status 1. /b/commit-queue/workdir/chromium/ui/resources/default_100_percent/ash/launcher_incognito_browser.png: Must not have executable ...
8 years, 4 months ago (2012-08-16 16:14:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davemoore@chromium.org/10823351/8004
8 years, 4 months ago (2012-08-16 17:18:24 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-16 17:18:35 UTC) #6
Presubmit check for 10823351-8004 failed and returned exit status 1.


Running presubmit commit checks ...
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 43, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1258, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1106, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1023, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 19, in CheckChangeOnCommit
  File "<string>", line 43, in _CommonChecks
  File
"/b/commit-queue/workdir/chromium/ui/resources/resource_check/resource_scale_factors.py",
line 93, in RunChecks
    width, height = ImageSize(image_path)
  File
"/b/commit-queue/workdir/chromium/ui/resources/resource_check/resource_scale_factors.py",
line 47, in ImageSize
    assert data[:8] == '\x89PNG\r\n\x1A\n' and data[12:16] == 'IHDR'
AssertionError

Powered by Google App Engine
This is Rietveld 408576698