Issue 10823335: fixing https redirect from old codesite url

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10823335: fixing https redirect from old codesite url (Closed)

Created:
8 years, 4 months ago by ernestd1

Modified:
8 years, 4 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix HTTPS redirect from old codesite URL. BUG=142727 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151622

Patch Set 2 : copy constant value for string replacement #

Patch Set 3 : fixed typo in main.py and pushed version on app.yaml #

Patch Set 4 : rebased with master #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	chrome/common/extensions/docs/server/app.yaml	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/common/extensions/docs/server/main.py	View	1 2	1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

https://chromiumcodereview.appspot.com/10823335/diff/1/chrome/common/extensions/docs/server/main.py File chrome/common/extensions/docs/server/main.py (right): https://chromiumcodereview.appspot.com/10823335/diff/1/chrome/common/extensions/docs/server/main.py#newcode179 chrome/common/extensions/docs/server/main.py:179: CHROME_DOMAIN_URL.replace('http', 'https', 1) You need to store the result ...

8 years, 4 months ago (2012-08-15 00:15:29 UTC) #2

lgtm