Issue 10823326: MIPS: Fix improved LoadICs for dictionaries with callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10823326: MIPS: Fix improved LoadICs for dictionaries with callbacks. (Closed)

Created:
8 years, 4 months ago by palfia

Modified:
8 years, 4 months ago

Reviewers:
kisg, Paul Lind, danno, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MIPS: Fix improved LoadICs for dictionaries with callbacks. Port r12311 (f698ddd7) Original commit message: This fixes the positive lookup performed by these LoadICs, to use the holder instead of the receiver to perfrom the lookup on. It also extends this improvement to KeyedLoadICs. And it fixes a bug introduced for the JavaScript getter case of a LoadIC. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=12314

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -15 lines)			Patch
	M	src/mips/stub-cache-mips.cc	View		6 chunks	+17 lines, -15 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM. Landing ...

Expand Messages | Collapse Messages