Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 10823319: [linux] change default monospace font to Monospace (Closed)

Created:
8 years, 4 months ago by Evan Stade
Modified:
8 years, 4 months ago
CC:
chromium-reviews, finnur+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

[linux] change default monospace font to Monospace Courier New looks bad on Linux. See bug for details. BUG=142485 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151791

Patch Set 1 #

Patch Set 2 : casing #

Patch Set 3 : restore casing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/app/resources/locale_settings_linux.grd View 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Evan Stade
justification is on the bug. I think 'monospace' uses the system default and appears to ...
8 years, 4 months ago (2012-08-14 18:30:29 UTC) #1
tony
Firefox also uses 'serif' and 'sans-serif' for serif and sans serif fonts. If we're going ...
8 years, 4 months ago (2012-08-15 00:13:30 UTC) #2
Evan Stade
On 2012/08/15 00:13:30, tony wrote: > Firefox also uses 'serif' and 'sans-serif' for serif and ...
8 years, 4 months ago (2012-08-15 00:29:49 UTC) #3
jungshik at Google
LGTM If you specify 'Monospace', what's actually used depends on what user/OS has in fontconfig ...
8 years, 4 months ago (2012-08-15 00:35:50 UTC) #4
tony
Ok, let's try it. No one uses Linux anyway, right? LGTM.
8 years, 4 months ago (2012-08-15 00:57:48 UTC) #5
tony
Nit: You might want to put part of the 'why' in the change description.
8 years, 4 months ago (2012-08-15 00:58:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/10823319/4001
8 years, 4 months ago (2012-08-15 21:12:08 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-15 23:52:07 UTC) #8
Change committed as 151791

Powered by Google App Engine
This is Rietveld 408576698