Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 10823316: Debug stub: Enable tests on x86-32 Windows (Closed)

Created:
8 years, 4 months ago by Mark Seaborn
Modified:
8 years, 4 months ago
Reviewers:
eaeltsin, bradn
CC:
native-client-reviews_googlegroups.com, eaeltsin
Visibility:
Public.

Description

Debug stub: Enable tests on x86-32 Windows Two recent changes make this possible: r9466 switches the debug stub to use the Windows debug exception handler process, which is essential for handling any x86-32 untrusted-code faults on Windows. r9489 fixes the memory access commands to work on x86-32 when mem_start != 0 and mem_start < 1GB, which is usually the case on 32-bit Windows. (In contrast, on Linux, we are using a zero-based x86-32 sandbox so mem_start == 0. Before the tests enabled the zero-based sandbox, the kernel would typically allocate addresses >1GB for mem_start.) BUG=http://code.google.com/p/nativeclient/issues/detail?id=2880 TEST=run_debug_stub_test + GDB tests in large_tests Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=9495

Patch Set 1 #

Patch Set 2 : Rerun try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M tests/debug_stub/nacl.scons View 1 chunk +1 line, -3 lines 0 comments Download
M tests/gdb/nacl.scons View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Seaborn
8 years, 4 months ago (2012-08-16 16:28:30 UTC) #1
eaeltsin
lgtm if bots are happy
8 years, 4 months ago (2012-08-16 16:43:35 UTC) #2
bradn
8 years, 4 months ago (2012-08-16 17:13:59 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698