Add RSAPrivateKey stub implementation for iOS.

Add RSAPrivateKey stub implementation for iOS.

RSAPrivateKey is not used on iOS, but code calling it is compiled. To avoid
ifdef'ing in the client code, the class is stubbed out.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152300

[stuartmorgan, 2012-08-14 10:00:39]

LGTM with nits:

s/dummy/stub/ in the CL description.

For the long description, instead of duplicating the whole comment, just say:

RSAPrivateKey is not used on iOS, but code calling it is compiled. To avoid
ifdef'ing in the client code, the class is stubbed out.

https://chromiumcodereview.appspot.com/10823309/diff/1/crypto/crypto.gyp
File crypto/crypto.gyp (right):

https://chromiumcodereview.appspot.com/10823309/diff/1/crypto/crypto.gyp#newc...
crypto/crypto.gyp:159: 'target_conditions' : [
For posterity: the reason this is in a target_conditional is that we'll be add
some 'sources/' re-includes that have to be in a target_conditional, it's
cleaner to keep all the iOS stuff grouped, and we don't want to do it the other
way when we know we'll almost immediately change it.

https://chromiumcodereview.appspot.com/10823309/diff/1/crypto/crypto.gyp#newc...
crypto/crypto.gyp:161: 'sources!': [
Indent this whole block 2 less.

https://chromiumcodereview.appspot.com/10823309/diff/1/crypto/crypto.gyp#newc...
crypto/crypto.gyp:162: 'rsa_private_key.cc',
Add a comment above this line:
# This class is stubbed out on iOS.

https://chromiumcodereview.appspot.com/10823309/diff/1/crypto/rsa_private_key...
File crypto/rsa_private_key_ios.cc (right):

https://chromiumcodereview.appspot.com/10823309/diff/1/crypto/rsa_private_key...
crypto/rsa_private_key_ios.cc:13: // implementation, but given it's lack of use,
that seems like doing more work
Change everything from "given it's lack" on to just "it hasn't yet been
necessary".

[msarda, 2012-08-14 12:55:16]

@Ryan: PTAL.

https://chromiumcodereview.appspot.com/10823309/diff/1/crypto/crypto.gyp
File crypto/crypto.gyp (right):

https://chromiumcodereview.appspot.com/10823309/diff/1/crypto/crypto.gyp#newc...
crypto/crypto.gyp:161: 'sources!': [
On 2012/08/14 10:00:39, stuartmorgan wrote:
> Indent this whole block 2 less.

Done.

https://chromiumcodereview.appspot.com/10823309/diff/1/crypto/crypto.gyp#newc...
crypto/crypto.gyp:162: 'rsa_private_key.cc',
On 2012/08/14 10:00:39, stuartmorgan wrote:
> Add a comment above this line:
> # This class is stubbed out on iOS.

Done.

https://chromiumcodereview.appspot.com/10823309/diff/1/crypto/rsa_private_key...
File crypto/rsa_private_key_ios.cc (right):

https://chromiumcodereview.appspot.com/10823309/diff/1/crypto/rsa_private_key...
crypto/rsa_private_key_ios.cc:13: // implementation, but given it's lack of use,
that seems like doing more work
On 2012/08/14 10:00:39, stuartmorgan wrote:
> Change everything from "given it's lack" on to just "it hasn't yet been
> necessary".

Done.

[Ryan Sleevi, 2012-08-14 17:31:50]

lgtm

[commit-bot: I haz the power, 2012-08-19 19:28:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msarda@chromium.org/10823309/2002

[commit-bot: I haz the power, 2012-08-20 01:11:53]

Change committed as 152300