Implement basic support for deferred slow path code with calls that save and restore live registers.

runtime/vm/locations.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_LOCATIONS_H_
 #define VM_LOCATIONS_H_
 
 #include "vm/allocation.h"
 #include "vm/assembler.h"
 #include "vm/bitfield.h"
@@ skipping 190 matching lines @@
   // Layout for kUnallocated locations payload.
   typedef BitField<Policy, 0, 2> PolicyField;
 
   // Location either contains kind and payload fields or a tagged handle for
   // a constant locations. Values of enumeration Kind are selected in such a
   // way that none of them can be interpreted as a kConstant tag.
   uword value_;
 };
 
 
+class RegisterSet : public ValueObject {
+ public:
+  RegisterSet() : registers_(0) {
+    ASSERT(kNumberOfCpuRegisters < (kWordSize * kBitsPerByte));
+  }
+
+  void Add(Register reg) {
+    registers_ |= (1 << reg);
+  }
+
+  bool Contains(Register reg) {
+    return (registers_ & (1 << reg)) != 0;
+  }
+
+ private:
+  intptr_t registers_;
+
+  DISALLOW_COPY_AND_ASSIGN(RegisterSet);
+};
+
+
 // Specification of locations for inputs and output.
 class LocationSummary : public ZoneAllocated {
  public:
   enum ContainsCall {
     kNoCall,
     kCall,
+    kCallOnSlowPath
   };
 
   LocationSummary(intptr_t input_count,
                   intptr_t temp_count,
                   LocationSummary::ContainsCall contains_call);
 
   intptr_t input_count() const {
     return input_locations_.length();
   }
 
@@ skipping 28 matching lines @@
   }
 
   Location out() const {
     return output_location_;
   }
 
   Location* out_slot() {
     return &output_location_;
   }
 
-
   void set_out(Location loc) {
     ASSERT(!is_call() || loc.IsRegister());
     output_location_ = loc;
   }
 
   BitmapBuilder* stack_bitmap() const { return stack_bitmap_; }
 
   bool is_call() const {
-    return is_call_;
+    return contains_call_ == kCall;
+  }
+
+  bool contains_call() const {

[srdjan, 2012/08/15 00:12:03]

I find is_call vs contains_call too similar/confusing

maybe is_always_call vs is_slow_path_call ?

Also, I would expect an accessor named contains_call() to return the field
contains_call_

[Vyacheslav Egorov (Google), 2012/08/15 13:08:07]

I rename contains_call() into can_call(), is_call into always_calls()

+    return contains_call_ != kNoCall;
   }
 
   void PrintTo(BufferFormatter* f) const;
 
   static LocationSummary* Make(intptr_t input_count,
                                Location out,
-                               LocationSummary::ContainsCall contains_call);
+                               ContainsCall contains_call);
+
+  RegisterSet* live_registers() {
+    return &live_registers_;
+  }
 
  private:
   // TODO(vegorov): replace with ZoneArray.
   GrowableArray<Location> input_locations_;
   GrowableArray<Location> temp_locations_;
   Location output_location_;
   BitmapBuilder* stack_bitmap_;
-  const bool is_call_;
+
+  const ContainsCall contains_call_;
+  RegisterSet live_registers_;
 };
 
 
 }  // namespace dart
 
 #endif  // VM_LOCATIONS_H_