Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 10823300: Make ChunkDemuxer::SetTimestampOffset take a TimeDelta instead of double (Closed)

Created:
8 years, 4 months ago by vrk (LEFT CHROMIUM)
Modified:
8 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Make ChunkDemuxer::SetTimestampOffset take a TimeDelta instead of double ChunkDemuxerTest.TestDurationChangeTimestampOffset tickled a precision error in 32-bit linux due to the division by InSecondsF(). This situation can be avoided by moving the double -> TimeDelta conversion into WebMediaPlayerImpl so that ChunkDemuxer can compute all times in terms of TimeDeltas. BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151601

Patch Set 1 #

Total comments: 1

Patch Set 2 : better solution #

Total comments: 4

Patch Set 3 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -22 lines) Patch
M media/filters/chunk_demuxer.h View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M media/filters/chunk_demuxer.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 1 6 chunks +15 lines, -9 lines 0 comments Download
M webkit/media/webmediaplayer_impl.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M webkit/media/webmediaplayer_proxy.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/media/webmediaplayer_proxy.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
vrk (LEFT CHROMIUM)
8 years, 4 months ago (2012-08-13 23:27:26 UTC) #1
Ami GONE FROM CHROMIUM
https://chromiumcodereview.appspot.com/10823300/diff/1/media/filters/chunk_demuxer_unittest.cc File media/filters/chunk_demuxer_unittest.cc (right): https://chromiumcodereview.appspot.com/10823300/diff/1/media/filters/chunk_demuxer_unittest.cc#newcode2332 media/filters/chunk_demuxer_unittest.cc:2332: kDefaultDuration().InSecondsF())); Per offline convo: IWBN if ChunkDemuxer dealt only ...
8 years, 4 months ago (2012-08-14 00:05:18 UTC) #2
vrk (LEFT CHROMIUM)
Thanks Ami, this is definitely the better way to go. PTAL.
8 years, 4 months ago (2012-08-14 01:06:43 UTC) #3
Ami GONE FROM CHROMIUM
LGTM https://chromiumcodereview.appspot.com/10823300/diff/3/media/filters/chunk_demuxer.h File media/filters/chunk_demuxer.h (right): https://chromiumcodereview.appspot.com/10823300/diff/3/media/filters/chunk_demuxer.h#newcode77 media/filters/chunk_demuxer.h:77: // Sets a time |offset| in seconds to ...
8 years, 4 months ago (2012-08-14 02:00:44 UTC) #4
vrk (LEFT CHROMIUM)
8 years, 4 months ago (2012-08-14 23:30:25 UTC) #5
https://chromiumcodereview.appspot.com/10823300/diff/3/media/filters/chunk_de...
File media/filters/chunk_demuxer.h (right):

https://chromiumcodereview.appspot.com/10823300/diff/3/media/filters/chunk_de...
media/filters/chunk_demuxer.h:77: // Sets a time |offset| in seconds to be
applied to subsequent buffers
On 2012/08/14 02:00:44, Ami Fischman wrote:
> drop "in seconds"

Done.

https://chromiumcodereview.appspot.com/10823300/diff/3/webkit/media/webmediap...
File webkit/media/webmediaplayer_impl.cc (right):

https://chromiumcodereview.appspot.com/10823300/diff/3/webkit/media/webmediap...
webkit/media/webmediaplayer_impl.cc:691: offset *
base::Time::kMicrosecondsPerSecond);
On 2012/08/14 02:00:44, Ami Fischman wrote:
> I suspect this wants to use webmediaplayer_util.h, but that can be another CL.

OK, Not Done Yet.

Powered by Google App Engine
This is Rietveld 408576698