Support resolution of indexed operators.

tests/compiler/dart2js/resolver_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #import('dart:uri');
 
 #import("../../../lib/compiler/implementation/leg.dart");
 #import("../../../lib/compiler/implementation/elements/elements.dart");
 #import("../../../lib/compiler/implementation/tree/tree.dart");
 #import("../../../lib/compiler/implementation/util/util.dart");
@@ skipping 55 matching lines @@
   // testTwoInterfaces(); // Generates unexpected error message.
   testFunctionExpression();
   testNewExpression();
   testTopLevelFields();
   testClassHierarchy();
   testInitializers();
   testThis();
   testSuperCalls();
   testTypeVariables();
   testToString();
+  testIndexedOperator();
 }
 
 testTypeVariables() {
   matchResolvedTypes(visitor, text, name, expectedElements) {
     VariableDefinitions definition = parseStatement(text);
     visitor.visit(definition.type);
     InterfaceType type = visitor.mapping.getType(definition.type);
     Expect.equals(definition.type.typeArguments.length(),
                   length(type.arguments));
     int index = 0;
@@ skipping 633 matching lines @@
 
 at(Link link, int index) => (index == 0) ? link.head : at(link.tail, index - 1);
 
 List<String> asSortedStrings(Link link) {
   List<String> result = <String>[];
   for (; !link.isEmpty(); link = link.tail) result.add(link.head.toString());
   result.sort((s1, s2) => s1.compareTo(s2));
   return result;
 }
 
+compileScript(String source, f(compiler)) {

[kasperl, 2012/08/14 07:13:13]

Could this just return the compiler instead?

[Anton Muhin, 2012/08/14 11:34:44]

Done.

+  Uri uri = new Uri.fromComponents(scheme: 'source');
+  MockCompiler compiler = compilerFor(source, uri);
+  compiler.runCompiler(uri);
+  f(compiler);
+}
+
 testToString() {
-  Uri uri = new Uri.fromComponents(scheme: 'source');
-  MockCompiler compiler = compilerFor(
-      @"class C { toString() => 'C'; } main() { '${new C()}'; }",
-      uri);
-  compiler.runCompiler(uri);
+  compileScript(@"class C { toString() => 'C'; } main() { '${new C()}'; }",

[kasperl, 2012/08/14 07:13:13]

Maybe stuff the script code in a string variable to make the callback argument
more readable.

[Anton Muhin, 2012/08/14 11:34:44]

Hopefully obsolete after addressing your previous comment.

On 2012/08/14 07:13:13, kasperl wrote:

+    (compiler) {
+    Element toStringMethod = findElement(compiler, 'C')
+        .lookupLocalMember(buildSourceString('toString'));
+    Expect.isNotNull(toStringMethod);
 
-  Element toStringMethod = findElement(compiler, 'C')
-      .lookupLocalMember(buildSourceString('toString'));
-  Expect.isNotNull(toStringMethod);
+    Expect.isNotNull(
+        compiler.enqueuer.resolution.getCachedElements(toStringMethod));
+  });
+}
 
-  Expect.isNotNull(
-      compiler.enqueuer.resolution.getCachedElements(toStringMethod));
+testIndexedOperator() {
+  compileScript(@"""

[kasperl, 2012/08/14 07:13:13]

Separate string variable for the script code.

[Anton Muhin, 2012/08/14 11:34:44]

Done.

+      class C {
+        operator[](ix) => ix;
+        operator[]=(ix, v) {}
+      }
+      main() { var c = new C(); c[0]++ ; }""",
+    (compiler) {
+    Element indexedOperator = findElement(compiler, 'C')
+        .lookupLocalMember(buildSourceString(@'operator$index'));

[kasperl, 2012/08/14 07:13:13]

It would be nice if you didn't have to hardcode the operator$index and the
operator$indexSet names here. Can you use Elements.constructOperatorName
instead? I'd rather hardcode [] and []=.

[Anton Muhin, 2012/08/14 11:34:44]

Done.

+    Expect.isNotNull(indexedOperator);
+    Expect.isNotNull(
+        compiler.enqueuer.resolution.getCachedElements(indexedOperator));
+
+    Element indexedSetOperator = findElement(compiler, 'C')
+        .lookupLocalMember(buildSourceString(@'operator$indexSet'));
+    Expect.isNotNull(indexedOperator);
+    Expect.isNotNull(
+        compiler.enqueuer.resolution.getCachedElements(indexedSetOperator));
+  });
 }