Exclude more files from Android build

Exclude more files from Android build

These files are not used on Android but were unnecessarily compiled.
They didn't affect binary size because they were removed during linker GC,
but excluding them may save build time, and help future modular exclusion.

BUG=none
TBR=ben,kbr,brettw,jar  (An Android only change to gyps)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151529

[Xianzhu, 2012-08-13 22:19:36]

Some notes about the changes

http://codereview.chromium.org/10823291/diff/9001/chrome/chrome_browser_exten...
File chrome/chrome_browser_extensions.gypi (left):

http://codereview.chromium.org/10823291/diff/9001/chrome/chrome_browser_exten...
chrome/chrome_browser_extensions.gypi:580:
'browser/extensions/api/webstore_private/webstore_private_api.h',
CL author note: These files are already excluded in enable_extensions==0
section, no need to specially listed in enable_extensions==1 section, so moved
back to the main 'sources' section.

http://codereview.chromium.org/10823291/diff/9001/chrome/chrome_browser_exten...
chrome/chrome_browser_extensions.gypi:725:
'browser/extensions/api/usb/usb_device_resource.h',
CL author note: These files are already excluded in enable_extensions==0
section.

[Jay Civelli, 2012-08-13 23:28:46]

lgtm

[Torne, 2012-08-14 09:29:33]

lgtm

http://codereview.chromium.org/10823291/diff/12004/base/base.gypi
File base/base.gypi (left):

http://codereview.chromium.org/10823291/diff/12004/base/base.gypi#oldcode575
base/base.gypi:575: ['OS == "android" and >(nacl_untrusted_build)==0', {
This condition reads really weirdly; I realise you didn't add this but it should
probably just be OS==android.

[Xianzhu, 2012-08-14 16:43:57]

http://codereview.chromium.org/10823291/diff/12004/base/base.gypi
File base/base.gypi (left):

http://codereview.chromium.org/10823291/diff/12004/base/base.gypi#oldcode575
base/base.gypi:575: ['OS == "android" and >(nacl_untrusted_build)==0', {
On 2012/08/14 09:29:33, Torne wrote:
> This condition reads really weirdly; I realise you didn't add this but it
should
> probably just be OS==android.

This was changed in https://chromiumcodereview.appspot.com/10389196. It also
looks weird and to me. Will ask the author of it.

[commit-bot: I haz the power, 2012-08-14 16:46:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/10823291/12004

[commit-bot: I haz the power, 2012-08-14 16:46:06]

Failed to apply patch for chrome/chrome_browser_extensions.gypi:
While running patch -p1 --forward --force;
patching file chrome/chrome_browser_extensions.gypi
Hunk #5 FAILED at 229.
Hunk #6 succeeded at 260 (offset 3 lines).
Hunk #7 succeeded at 361 (offset 3 lines).
Hunk #8 succeeded at 387 (offset 3 lines).
Hunk #9 succeeded at 473 (offset 3 lines).
Hunk #10 succeeded at 495 (offset 3 lines).
Hunk #11 succeeded at 523 (offset 3 lines).
Hunk #12 succeeded at 583 (offset 3 lines).
Hunk #13 succeeded at 625 (offset 3 lines).
Hunk #14 succeeded at 718 (offset 3 lines).
1 out of 14 hunks FAILED -- saving rejects to file
chrome/chrome_browser_extensions.gypi.rej

[commit-bot: I haz the power, 2012-08-14 16:51:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/10823291/13003

[commit-bot: I haz the power, 2012-08-14 16:51:59]

Presubmit check for 10823291-13003 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome
    ui/gl
    content
    base
    ui
    webkit/media
    net

Presubmit checks took 1.1s to calculate.

[commit-bot: I haz the power, 2012-08-14 16:55:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/10823291/13003

[commit-bot: I haz the power, 2012-08-14 19:10:36]

Change committed as 151529