Reland http://codereview.chromium.org/10831279/

chrome/browser/chromeos/gdata/gdata_cache_unittest.cc

Index: chrome/browser/chromeos/gdata/gdata_cache_unittest.cc
diff --git a/chrome/browser/chromeos/gdata/gdata_cache_unittest.cc b/chrome/browser/chromeos/gdata/gdata_cache_unittest.cc
index 449dd6d7e2604c1d56206b2b380f4e383f4cb3ea..d92967c0c74211b5875147a1df7a9292a95bc035 100644
--- a/chrome/browser/chromeos/gdata/gdata_cache_unittest.cc
+++ b/chrome/browser/chromeos/gdata/gdata_cache_unittest.cc
@@ -809,6 +809,9 @@ TEST_F(GDataCacheTest, GetCacheFilePath) {
 }
 
 TEST_F(GDataCacheTest, StoreToCacheSimple) {
+  EXPECT_CALL(*mock_free_disk_space_checker_, AmountOfFreeDiskSpace())
+      .Times(AtLeast(1)).WillRepeatedly(Return(kLotsOfSpace));
+
   std::string resource_id("pdf:1a2b");
   std::string md5("abcdef0123456789");
 
@@ -841,6 +844,9 @@ TEST_F(GDataCacheTest, StoreToCacheSimple) {
 }
 
 TEST_F(GDataCacheTest, GetFromCacheSimple) {
+  EXPECT_CALL(*mock_free_disk_space_checker_, AmountOfFreeDiskSpace())
+      .Times(AtLeast(1)).WillRepeatedly(Return(kLotsOfSpace));
+
   std::string resource_id("pdf:1a2b");
   std::string md5("abcdef0123456789");
   // First store a file to cache.
@@ -871,6 +877,9 @@ TEST_F(GDataCacheTest, GetFromCacheSimple) {
 }
 
 TEST_F(GDataCacheTest, RemoveFromCacheSimple) {
+  EXPECT_CALL(*mock_free_disk_space_checker_, AmountOfFreeDiskSpace())
+      .Times(AtLeast(1)).WillRepeatedly(Return(kLotsOfSpace));
+
   // Use alphanumeric characters for resource id.
   std::string resource_id("pdf:1a2b");
   std::string md5("abcdef0123456789");
@@ -970,6 +979,9 @@ TEST_F(GDataCacheTest, PinAndUnpin) {
 }
 
 TEST_F(GDataCacheTest, StoreToCachePinned) {
+  EXPECT_CALL(*mock_free_disk_space_checker_, AmountOfFreeDiskSpace())
+      .Times(AtLeast(1)).WillRepeatedly(Return(kLotsOfSpace));
+
   std::string resource_id("pdf:1a2b");
   std::string md5("abcdef0123456789");
   EXPECT_CALL(*mock_cache_observer_, OnCachePinned(resource_id, md5)).Times(1);
@@ -1001,6 +1013,9 @@ TEST_F(GDataCacheTest, StoreToCachePinned) {
 }
 
 TEST_F(GDataCacheTest, GetFromCachePinned) {
+  EXPECT_CALL(*mock_free_disk_space_checker_, AmountOfFreeDiskSpace())
+      .Times(AtLeast(1)).WillRepeatedly(Return(kLotsOfSpace));
+
   std::string resource_id("pdf:1a2b");
   std::string md5("abcdef0123456789");
   EXPECT_CALL(*mock_cache_observer_, OnCachePinned(resource_id, md5)).Times(1);
@@ -1032,6 +1047,9 @@ TEST_F(GDataCacheTest, GetFromCachePinned) {
 }
 
 TEST_F(GDataCacheTest, RemoveFromCachePinned) {
+  EXPECT_CALL(*mock_free_disk_space_checker_, AmountOfFreeDiskSpace())
+      .Times(AtLeast(1)).WillRepeatedly(Return(kLotsOfSpace));
+
   // Use alphanumeric characters for resource_id.
   std::string resource_id("pdf:1a2b");
   std::string md5("abcdef0123456789");
@@ -1072,6 +1090,9 @@ TEST_F(GDataCacheTest, RemoveFromCachePinned) {
 }
 
 TEST_F(GDataCacheTest, DirtyCacheSimple) {
+  EXPECT_CALL(*mock_free_disk_space_checker_, AmountOfFreeDiskSpace())
+      .Times(AtLeast(1)).WillRepeatedly(Return(kLotsOfSpace));
+
   std::string resource_id("pdf:1a2b");
   std::string md5("abcdef0123456789");
   EXPECT_CALL(*mock_cache_observer_, OnCacheCommitted(resource_id)).Times(1);
@@ -1108,6 +1129,9 @@ TEST_F(GDataCacheTest, DirtyCacheSimple) {
 }
 
 TEST_F(GDataCacheTest, DirtyCachePinned) {
+  EXPECT_CALL(*mock_free_disk_space_checker_, AmountOfFreeDiskSpace())
+      .Times(AtLeast(1)).WillRepeatedly(Return(kLotsOfSpace));
+
   std::string resource_id("pdf:1a2b");
   std::string md5("abcdef0123456789");
   EXPECT_CALL(*mock_cache_observer_, OnCachePinned(resource_id, md5)).Times(1);
@@ -1205,6 +1229,9 @@ TEST_F(GDataCacheTest, PinAndUnpinDirtyCache) {
 }
 
 TEST_F(GDataCacheTest, DirtyCacheRepetitive) {
+  EXPECT_CALL(*mock_free_disk_space_checker_, AmountOfFreeDiskSpace())
+      .Times(AtLeast(1)).WillRepeatedly(Return(kLotsOfSpace));
+
   std::string resource_id("pdf:1a2b");
   std::string md5("abcdef0123456789");
   EXPECT_CALL(*mock_cache_observer_, OnCacheCommitted(resource_id)).Times(3);
@@ -1285,6 +1312,9 @@ TEST_F(GDataCacheTest, DirtyCacheRepetitive) {
 }
 
 TEST_F(GDataCacheTest, DirtyCacheInvalid) {
+  EXPECT_CALL(*mock_free_disk_space_checker_, AmountOfFreeDiskSpace())
+      .Times(AtLeast(1)).WillRepeatedly(Return(kLotsOfSpace));
+
   std::string resource_id("pdf:1a2b");
   std::string md5("abcdef0123456789");
 
@@ -1347,6 +1377,9 @@ TEST_F(GDataCacheTest, DirtyCacheInvalid) {
 }
 
 TEST_F(GDataCacheTest, RemoveFromDirtyCache) {
+  EXPECT_CALL(*mock_free_disk_space_checker_, AmountOfFreeDiskSpace())
+      .Times(AtLeast(1)).WillRepeatedly(Return(kLotsOfSpace));
+
   std::string resource_id("pdf:1a2b");
   std::string md5("abcdef0123456789");
   EXPECT_CALL(*mock_cache_observer_, OnCachePinned(resource_id, md5)).Times(1);
@@ -1382,6 +1415,9 @@ TEST_F(GDataCacheTest, RemoveFromDirtyCache) {
 }
 
 TEST_F(GDataCacheTest, MountUnmount) {
+  EXPECT_CALL(*mock_free_disk_space_checker_, AmountOfFreeDiskSpace())
+      .Times(AtLeast(1)).WillRepeatedly(Return(kLotsOfSpace));
+
   FilePath file_path;
   std::string resource_id("pdf:1a2b");
   std::string md5("abcdef0123456789");
@@ -1479,6 +1515,9 @@ TEST_F(GDataCacheTest, GetResourceIdsOfAllFilesOnUIThread) {
 TEST_F(GDataCacheTest, ClearAllOnUIThread) {
   PrepareForInitCacheTest();
 
+  EXPECT_CALL(*mock_free_disk_space_checker_, AmountOfFreeDiskSpace())
+      .Times(AtLeast(1)).WillRepeatedly(Return(kLotsOfSpace));
+
   std::string resource_id("pdf:1a2b");
   std::string md5("abcdef0123456789");
 
@@ -1505,4 +1544,23 @@ TEST_F(GDataCacheTest, ClearAllOnUIThread) {
   EXPECT_EQ(0U, CountCacheFiles(resource_id, md5));
 }
 
+TEST_F(GDataCacheTest, StoreToCacheNoSpace) {
+  EXPECT_CALL(*mock_free_disk_space_checker_, AmountOfFreeDiskSpace())
+      .Times(AtLeast(1)).WillRepeatedly(Return(0));
+
+  std::string resource_id("pdf:1a2b");
+  std::string md5("abcdef0123456789");
+
+  // Try to store an existing file.
+  TestStoreToCache(resource_id, md5, GetTestFilePath("root_feed.json"),
+                   GDATA_FILE_ERROR_NO_SPACE,
+                   test_util::TEST_CACHE_STATE_NONE,
+                   GDataCache::CACHE_TYPE_TMP);
+  EXPECT_EQ(1, num_callback_invocations_);
+
+  // Verify that there's no files added.
+  EXPECT_EQ(0U, CountCacheFiles(resource_id, md5));
+}
+
+
 }   // namespace gdata