Use type propagation for removing Smi checks in binary operations and comparisons. Regis will adapt…

runtime/vm/intermediate_language.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/intermediate_language.h"
 
 #include "vm/bit_vector.h"
 #include "vm/dart_entry.h"
 #include "vm/flow_graph_allocator.h"
 #include "vm/flow_graph_builder.h"
 #include "vm/flow_graph_compiler.h"
 #include "vm/locations.h"
 #include "vm/object.h"
+#include "vm/object_store.h"
 #include "vm/os.h"
 #include "vm/scopes.h"
 #include "vm/stub_code.h"
 #include "vm/symbols.h"
 
 namespace dart {
 
 DECLARE_FLAG(bool, enable_type_checks);
 
 UseVal::UseVal(Definition* definition)
@@ skipping 736 matching lines @@
   return AbstractType::null();
 }
 
 
 RawAbstractType* CatchEntryComp::CompileType() const {
   return AbstractType::null();
 }
 
 
 RawAbstractType* CheckStackOverflowComp::CompileType() const {
-  return Type::VoidType();
+  return AbstractType::null();
 }
 
 
 RawAbstractType* BinaryOpComp::CompileType() const {
-  // TODO(srdjan): Compute based on input types (ICData).
-  return Type::DynamicType();
+  // TODO(srdjan): Convert to use with class-ids instead of types.
+  if (operands_type() == kMintOperands) {
+    ObjectStore* object_store = Isolate::Current()->object_store();
+    return Type::NewNonParameterizedType(
+        Class::Handle(object_store->mint_class()));

[regis, 2012/08/10 23:18:49]

Add a TODO to add SmiType, MintType, and DoubleType to the object store. There
is a similar TODO elsewhere. This will be more efficient that allocating a new
type each time. 

[srdjan, 2012/08/10 23:30:05]

Done.

+  } else if (op_kind() == Token::kSHL) {
+    return Type::IntInterface();
+  } else {
+    ASSERT(operands_type() == kSmiOperands);
+    ObjectStore* object_store = Isolate::Current()->object_store();
+    return Type::NewNonParameterizedType(
+        Class::Handle(object_store->smi_class()));
+  }
 }
 
 
 RawAbstractType* DoubleBinaryOpComp::CompileType() const {
   return Type::DoubleInterface();
 }
 
 
 RawAbstractType* UnarySmiOpComp::CompileType() const {
   return Type::IntInterface();
@@ skipping 447 matching lines @@
   if (compiler->is_ssa()) {
     ASSERT(locs()->in(0).IsRegister());
     __ PushRegister(locs()->in(0).reg());
   }
 }
 
 
 #undef __
 
 }  // namespace dart